diff mbox series

[U-Boot] rockchip: enable SPL_SYSRESET config for all sockchip SoCs

Message ID 1504839654-16808-1-git-send-email-kever.yang@rock-chips.com
State Accepted
Delegated to: Philipp Tomsich
Headers show
Series [U-Boot] rockchip: enable SPL_SYSRESET config for all sockchip SoCs | expand

Commit Message

Kever Yang Sept. 8, 2017, 3 a.m. UTC
After the patch below, we need to add SPL_SYSRESET for do_reset()
in SPL:
87c16d4 drivers: spl: consistently use the $(SPL_TPL_) macro

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Philipp Tomsich Sept. 8, 2017, 8:39 a.m. UTC | #1
> After the patch below, we need to add SPL_SYSRESET for do_reset()
> in SPL:
> 87c16d4 drivers: spl: consistently use the $(SPL_TPL_) macro
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Sept. 8, 2017, 8:39 a.m. UTC | #2
> After the patch below, we need to add SPL_SYSRESET for do_reset()
> in SPL:
> 87c16d4 drivers: spl: consistently use the $(SPL_TPL_) macro
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Sept. 8, 2017, 9:25 a.m. UTC | #3
Kever,

Note that this patch applies neither to master nor to next cleanly.
Given that it’s a single line change, I’ll patch this in by hand.

Thanks,
Philipp.


> On 8 Sep 2017, at 05:00, Kever Yang <kever.yang@rock-chips.com> wrote:
> 
> After the patch below, we need to add SPL_SYSRESET for do_reset()
> in SPL:
> 87c16d4 drivers: spl: consistently use the $(SPL_TPL_) macro
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e01b72e..7872cfd 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1118,6 +1118,7 @@ config ARCH_ROCKCHIP
> 	imply USB_FUNCTION_FASTBOOT
> 	imply USB_FUNCTION_ROCKUSB
> 	imply CMD_ROCKUSB
> +	imply SPL_SYSRESET
> 
> config TARGET_THUNDERX_88XX
> 	bool "Support ThunderX 88xx"
> -- 
> 1.9.1
>
Philipp Tomsich Sept. 8, 2017, 9:44 a.m. UTC | #4
> After the patch below, we need to add SPL_SYSRESET for do_reset()
> in SPL:
> 87c16d4 drivers: spl: consistently use the $(SPL_TPL_) macro
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied to u-boot-rockchip, thanks!
Kever Yang Sept. 11, 2017, 2:06 a.m. UTC | #5
Philipp,

     Sorry for it can not be applied directly, I believe that's because 
the rockusb

patch still not applied.


Thanks,
- Kever
On 09/08/2017 05:25 PM, Dr. Philipp Tomsich wrote:
> Kever,
>
> Note that this patch applies neither to master nor to next cleanly.
> Given that it’s a single line change, I’ll patch this in by hand.
>
> Thanks,
> Philipp.
>
>
>> On 8 Sep 2017, at 05:00, Kever Yang <kever.yang@rock-chips.com> wrote:
>>
>> After the patch below, we need to add SPL_SYSRESET for do_reset()
>> in SPL:
>> 87c16d4 drivers: spl: consistently use the $(SPL_TPL_) macro
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> arch/arm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index e01b72e..7872cfd 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1118,6 +1118,7 @@ config ARCH_ROCKCHIP
>> 	imply USB_FUNCTION_FASTBOOT
>> 	imply USB_FUNCTION_ROCKUSB
>> 	imply CMD_ROCKUSB
>> +	imply SPL_SYSRESET
>>
>> config TARGET_THUNDERX_88XX
>> 	bool "Support ThunderX 88xx"
>> -- 
>> 1.9.1
>>
>
diff mbox series

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e01b72e..7872cfd 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1118,6 +1118,7 @@  config ARCH_ROCKCHIP
 	imply USB_FUNCTION_FASTBOOT
 	imply USB_FUNCTION_ROCKUSB
 	imply CMD_ROCKUSB
+	imply SPL_SYSRESET
 
 config TARGET_THUNDERX_88XX
 	bool "Support ThunderX 88xx"