| Message ID | 1296214933-28693-1-git-send-email-holler@ahsoftware.de |
|---|---|
| State | Accepted |
| Commit | ce297a8f7e6134b2dcbf4d180b1183a884f73c30 |
| Delegated to: | Remy Bohmer |
| Headers | show |
Hi, 2011/1/28 Alexander Holler <holler@ahsoftware.de>: > While debugging some USB stuff, I've first missed that there are actually > two defines necessary to get usefull output. The one needed to get debug output > for the communication with HUBs was burried somewhere deep inside the code. > > Change that so that a #define DEBUG is enough while still leaving the possibility > to reduce unwanted debug output. > > Signed-off-by: Alexander Holler <holler@ahsoftware.de> > --- > common/usb.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) Applied to u-boot-usb. Thanks. Remy
diff --git a/common/usb.c b/common/usb.c index 10e23de..ee580ec 100644 --- a/common/usb.c +++ b/common/usb.c @@ -55,7 +55,10 @@ #include <asm/4xx_pci.h> #endif -#undef USB_DEBUG +#ifdef DEBUG +#define USB_DEBUG +#define USB_HUB_DEBUG +#endif #ifdef USB_DEBUG #define USB_PRINTF(fmt, args...) printf(fmt , ##args) @@ -960,8 +963,6 @@ void usb_scan_devices(void) * Probes device for being a hub and configurate it */ -#undef USB_HUB_DEBUG - #ifdef USB_HUB_DEBUG #define USB_HUB_PRINTF(fmt, args...) printf(fmt , ##args) #else
While debugging some USB stuff, I've first missed that there are actually two defines necessary to get usefull output. The one needed to get debug output for the communication with HUBs was burried somewhere deep inside the code. Change that so that a #define DEBUG is enough while still leaving the possibility to reduce unwanted debug output. Signed-off-by: Alexander Holler <holler@ahsoftware.de> --- common/usb.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)