diff mbox

[4/3] improve detection of attribute conflicts (PR 81544)

Message ID 8e37236c-83eb-7c8f-bffd-6f28a2701a10@gmail.com
State New
Headers show

Commit Message

Martin Sebor Aug. 16, 2017, 10:38 p.m. UTC 
Jon,

Attached is the libstdc++ only patch to remove the pointless
const attribute from __pool<true>::_M_destroy_thread_key(void*).

   https://gcc.gnu.org/ml/gcc/2017-08/msg00027.html

I only belatedly now broke it out of the larger patch under
review here:

   https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00599.html

Thanks
Martin

Comments

Jonathan Wakely Aug. 18, 2017, 1:57 p.m. UTC | #1 
On 16/08/17 16:38 -0600, Martin Sebor wrote:
>Jon,
>
>Attached is the libstdc++ only patch to remove the pointless
>const attribute from __pool<true>::_M_destroy_thread_key(void*).
>
>  https://gcc.gnu.org/ml/gcc/2017-08/msg00027.html
>
>I only belatedly now broke it out of the larger patch under
>review here:
>
>  https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00599.html
>
>Thanks
>Martin

>libstdc++-v3/ChangeLog:
>
>	PR c/81544
>	* include/ext/mt_allocator.h (_M_destroy_thread_key): Remove
>	pointless attribute const.

OK.

>diff --git a/libstdc++-v3/include/ext/mt_allocator.h b/libstdc++-v3/include/ext/mt_allocator.h
>index effb13b..f349ff8 100644
>--- a/libstdc++-v3/include/ext/mt_allocator.h
>+++ b/libstdc++-v3/include/ext/mt_allocator.h
>@@ -355,7 +355,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>       }
> 
>       // XXX GLIBCXX_ABI Deprecated
>-      _GLIBCXX_CONST void 
>+      void
>       _M_destroy_thread_key(void*) throw ();
> 
>       size_t
diff mbox

Patch

libstdc++-v3/ChangeLog:

	PR c/81544
	* include/ext/mt_allocator.h (_M_destroy_thread_key): Remove
	pointless attribute const.

diff --git a/libstdc++-v3/include/ext/mt_allocator.h b/libstdc++-v3/include/ext/mt_allocator.h
index effb13b..f349ff8 100644
--- a/libstdc++-v3/include/ext/mt_allocator.h
+++ b/libstdc++-v3/include/ext/mt_allocator.h
@@ -355,7 +355,7 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
       }
 
       // XXX GLIBCXX_ABI Deprecated
-      _GLIBCXX_CONST void 
+      void
       _M_destroy_thread_key(void*) throw ();
 
       size_t