From patchwork Wed Aug 16 22:38:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sebor X-Patchwork-Id: 802270 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-460465-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="gsedPPq6"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xXklP42Lyz9t38 for ; Thu, 17 Aug 2017 08:38:22 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=tFIN3fHUkDJhGSSgL fd9cX62xf+8ZlFwODm1BmoGtNQbwI7ohyDOq0CtyXJsvsXr/k/MxKFXfi4cQ/CxT A9BCGqo7NwcXlH4sCZ7WASU5M5Aamqs/nuRqAdeOwFf3fx/dQmpYGeQxEBnHsZd1 eCcIqvJU0FEe3J0rf3yGVvqBSU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=yHuNqQKD5RFjd/Is37x5WOz sZGo=; b=gsedPPq6a/SHbO7BtrEJ53DGJHFD3ngTP64613NCjJnTMdOd7ZOmLVQ yCkIANT4FL+DDNwgj7OERSReOtwQg1Wo/aOInpIlmxlhwlGc7gqk8bLekjKWzgR/ SXpZY13Vh7A/Z8RvG9rvG6qnnQvFI9Cf5+Kt+kXFJsTC+AMCdBkE= Received: (qmail 78019 invoked by alias); 16 Aug 2017 22:38:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 75150 invoked by uid 89); 16 Aug 2017 22:38:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=xxx X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-qt0-f193.google.com Received: from mail-qt0-f193.google.com (HELO mail-qt0-f193.google.com) (209.85.216.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Aug 2017 22:38:09 +0000 Received: by mail-qt0-f193.google.com with SMTP id i19so4808547qte.1; Wed, 16 Aug 2017 15:38:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=PORuIssrCfsBDWL/0qOXrE78ZFBVGUSUxzIMnG216bM=; b=PeiwY2INaoHvR34k79musCClooYnkduYzVyTIBHPyEQpR8QVG0F0AgHKjzAHtNH4Kz Rnf9gRPis0oklF0WxWSrNr6XP2SLGW6kM40KqANVZoQV2koow3B/o2XoenXLcL8Pth28 Urdzh1szNrzGiPtsOQ81vQwQ4A4cPbdhl0mNgpoIssZsKjCX2tiHGQsUYoOLH6Ve8RTF cx1x1WWlUl4HgQfeMOZ03HEMK5TX3n1IEVQxEezwVn1uH8jMvoShOg0M2vQS1GcnjlBa tA0u+44h0WrbU+C12WCx66SW3XW1WHRf+dGGVRcdwlLgyEYwxcfKEPXw7MzTzxkAuzy9 YOMg== X-Gm-Message-State: AHYfb5jDAtETbTgMbUmbiPABdoxRBWsfQuDxrIq5CvzSUFtH7tVdNVVy /husuQaWLDUaqVV3 X-Received: by 10.200.28.41 with SMTP id a38mr4447783qtk.262.1502923085815; Wed, 16 Aug 2017 15:38:05 -0700 (PDT) Received: from localhost.localdomain (174-16-125-25.hlrn.qwest.net. [174.16.125.25]) by smtp.gmail.com with ESMTPSA id t1sm1285671qkb.91.2017.08.16.15.38.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2017 15:38:05 -0700 (PDT) Subject: [PATCH 4/3] improve detection of attribute conflicts (PR 81544) To: Jonathan Wakely References: <4899e27e-6fc3-a887-7888-9f7810a07aaa@gmail.com> Cc: Gcc Patch List , libstdc++ From: Martin Sebor Message-ID: <8e37236c-83eb-7c8f-bffd-6f28a2701a10@gmail.com> Date: Wed, 16 Aug 2017 16:38:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <4899e27e-6fc3-a887-7888-9f7810a07aaa@gmail.com> X-IsSubscribed: yes Jon, Attached is the libstdc++ only patch to remove the pointless const attribute from __pool::_M_destroy_thread_key(void*). https://gcc.gnu.org/ml/gcc/2017-08/msg00027.html I only belatedly now broke it out of the larger patch under review here: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00599.html Thanks Martin libstdc++-v3/ChangeLog: PR c/81544 * include/ext/mt_allocator.h (_M_destroy_thread_key): Remove pointless attribute const. diff --git a/libstdc++-v3/include/ext/mt_allocator.h b/libstdc++-v3/include/ext/mt_allocator.h index effb13b..f349ff8 100644 --- a/libstdc++-v3/include/ext/mt_allocator.h +++ b/libstdc++-v3/include/ext/mt_allocator.h @@ -355,7 +355,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } // XXX GLIBCXX_ABI Deprecated - _GLIBCXX_CONST void + void _M_destroy_thread_key(void*) throw (); size_t