diff mbox

[U-Boot,12/18] rockchip: sdhci: Convert to livetree

Message ID 1502904758-7562-13-git-send-email-philipp.tomsich@theobroma-systems.com
State Superseded
Delegated to: Philipp Tomsich
Headers show

Commit Message

Philipp Tomsich Aug. 16, 2017, 5:32 p.m. UTC
Update the Rockchip SDHCI wrapper to support a live device tree.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---

 drivers/mmc/rockchip_sdhci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Philipp Tomsich Aug. 18, 2017, 4:12 p.m. UTC | #1
> Update the Rockchip SDHCI wrapper to support a live device tree.
> 
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  drivers/mmc/rockchip_sdhci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Simon Glass Aug. 26, 2017, 1:40 p.m. UTC | #2
On 16 August 2017 at 11:32, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> Update the Rockchip SDHCI wrapper to support a live device tree.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
>  drivers/mmc/rockchip_sdhci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Please see below.

>
> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
> index f31d329..8d62bf9 100644
> --- a/drivers/mmc/rockchip_sdhci.c
> +++ b/drivers/mmc/rockchip_sdhci.c
> @@ -9,7 +9,6 @@
>  #include <common.h>
>  #include <dm.h>
>  #include <dt-structs.h>
> -#include <fdtdec.h>
>  #include <libfdt.h>
>  #include <malloc.h>
>  #include <mapmem.h>
> @@ -82,7 +81,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev)
>         struct sdhci_host *host = dev_get_priv(dev);
>
>         host->name = dev->name;
> -       host->ioaddr = devfdt_get_addr_ptr(dev);
> +       host->ioaddr = (void *)dev_read_addr(dev);

Can you please add a dev_read_addr_ptr() ?

>  #endif
>
>         return 0;
> --
> 2.1.4
>
diff mbox

Patch

diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
index f31d329..8d62bf9 100644
--- a/drivers/mmc/rockchip_sdhci.c
+++ b/drivers/mmc/rockchip_sdhci.c
@@ -9,7 +9,6 @@ 
 #include <common.h>
 #include <dm.h>
 #include <dt-structs.h>
-#include <fdtdec.h>
 #include <libfdt.h>
 #include <malloc.h>
 #include <mapmem.h>
@@ -82,7 +81,7 @@  static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev)
 	struct sdhci_host *host = dev_get_priv(dev);
 
 	host->name = dev->name;
-	host->ioaddr = devfdt_get_addr_ptr(dev);
+	host->ioaddr = (void *)dev_read_addr(dev);
 #endif
 
 	return 0;