diff mbox

[U-Boot,2/3] am335x_hs_evm: Disable CONFIG_SPL_ENV_SUPPORT

Message ID 1501089097-14940-2-git-send-email-trini@konsulko.com
State Accepted
Commit 3c7be0c91a1e03d12a068c275dc0fbf863b5acbe
Delegated to: Tom Rini
Headers show

Commit Message

Tom Rini July 26, 2017, 5:11 p.m. UTC
The main uses of CONFIG_SPL_ENV_SUPPORT are for network support and for
disabling "Falcon Mode" support at run-time.  As this build enables
neither, remove this feature.

Cc: Andrew F. Davis <afd@ti.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 configs/am335x_hs_evm_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Lokesh Vutla July 27, 2017, 2:46 a.m. UTC | #1
On 7/26/2017 10:41 PM, Tom Rini wrote:
> The main uses of CONFIG_SPL_ENV_SUPPORT are for network support and for
> disabling "Falcon Mode" support at run-time.  As this build enables
> neither, remove this feature.
> 
> Cc: Andrew F. Davis <afd@ti.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

> ---
>  configs/am335x_hs_evm_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/am335x_hs_evm_defconfig b/configs/am335x_hs_evm_defconfig
> index 2b1acb70d18f..ffdbe7585573 100644
> --- a/configs/am335x_hs_evm_defconfig
> +++ b/configs/am335x_hs_evm_defconfig
> @@ -18,6 +18,7 @@ CONFIG_VERSION_VARIABLE=y
>  CONFIG_ARCH_MISC_INIT=y
>  CONFIG_SPL=y
>  CONFIG_SPL_STACK_R=y
> +# CONFIG_SPL_ENV_SUPPORT is not set
>  # CONFIG_SPL_EXT_SUPPORT is not set
>  CONFIG_SPL_MTD_SUPPORT=y
>  # CONFIG_SPL_YMODEM_SUPPORT is not set
>
Simon Glass July 31, 2017, 2:45 p.m. UTC | #2
On 26 July 2017 at 20:46, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>
>
> On 7/26/2017 10:41 PM, Tom Rini wrote:
>> The main uses of CONFIG_SPL_ENV_SUPPORT are for network support and for
>> disabling "Falcon Mode" support at run-time.  As this build enables
>> neither, remove this feature.
>>
>> Cc: Andrew F. Davis <afd@ti.com>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
>
> Thanks and regards,
> Lokesh
>
>> ---
>>  configs/am335x_hs_evm_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/am335x_hs_evm_defconfig b/configs/am335x_hs_evm_defconfig
>> index 2b1acb70d18f..ffdbe7585573 100644
>> --- a/configs/am335x_hs_evm_defconfig
>> +++ b/configs/am335x_hs_evm_defconfig
>> @@ -18,6 +18,7 @@ CONFIG_VERSION_VARIABLE=y
>>  CONFIG_ARCH_MISC_INIT=y
>>  CONFIG_SPL=y
>>  CONFIG_SPL_STACK_R=y
>> +# CONFIG_SPL_ENV_SUPPORT is not set
>>  # CONFIG_SPL_EXT_SUPPORT is not set
>>  CONFIG_SPL_MTD_SUPPORT=y
>>  # CONFIG_SPL_YMODEM_SUPPORT is not set

Reviewed-by: Simon Glass <sjg@chromium.org>

>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Tom Rini Aug. 1, 2017, 12:41 a.m. UTC | #3
On Wed, Jul 26, 2017 at 01:11:36PM -0400, Tom Rini wrote:

> The main uses of CONFIG_SPL_ENV_SUPPORT are for network support and for
> disabling "Falcon Mode" support at run-time.  As this build enables
> neither, remove this feature.
> 
> Cc: Andrew F. Davis <afd@ti.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/configs/am335x_hs_evm_defconfig b/configs/am335x_hs_evm_defconfig
index 2b1acb70d18f..ffdbe7585573 100644
--- a/configs/am335x_hs_evm_defconfig
+++ b/configs/am335x_hs_evm_defconfig
@@ -18,6 +18,7 @@  CONFIG_VERSION_VARIABLE=y
 CONFIG_ARCH_MISC_INIT=y
 CONFIG_SPL=y
 CONFIG_SPL_STACK_R=y
+# CONFIG_SPL_ENV_SUPPORT is not set
 # CONFIG_SPL_EXT_SUPPORT is not set
 CONFIG_SPL_MTD_SUPPORT=y
 # CONFIG_SPL_YMODEM_SUPPORT is not set