| Message ID | 291153589ecb2247033d5b23ae6bc9b852eef7f3.1501017251.git.yann.morin.1998@free.fr |
|---|---|
| State | Superseded |
| Headers | show |
On 25-07-17 23:14, Yann E. MORIN wrote: > When there is no init system (i.e. a custom one), our bundled default > skeleton is most probably un-fit for that (non-)init system. > > This will be the case when we introduce per init system skeletons. The > systemd skeleton will be unfit except for a systemd init; the sysv > skeleton will be unfit except for a sysv-like init system. > > In case they are using no init system (really, a custom one), the user > should be responsible for providing their own, custom skeleton as well. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> There is actually a problem with this one. A lot of our tests in support/testing, as well as the test-pkg script and the autobuilders, will build with BR2_INIT_NONE=y but without specifying a custom skeleton. That makes this series essentially non-bisectable. Thomas, Peter, how bad a problem do you think this is? Yann, how bad would it be to rebase the series without this patch? At first sight, up to patch 7 should be independent of it... Regards, Arnout > --- > system/Config.in | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/system/Config.in b/system/Config.in > index 828df4217e..ed539dcbe0 100644 > --- a/system/Config.in > +++ b/system/Config.in > @@ -3,11 +3,17 @@ menu "System configuration" > choice > prompt "Root FS skeleton" > > +# When not using an init system (i.e. a custom one), our default skeleton > +# is most probably unfit; so, allow only the custom skeleton in that case. > config BR2_ROOTFS_SKELETON_DEFAULT > bool "default target skeleton" > + depends on !BR2_INIT_NONE > help > Use default target skeleton > > +comment "default target skeleton needs an init system" > + depends on BR2_INIT_NONE > + > config BR2_ROOTFS_SKELETON_CUSTOM > bool "custom target skeleton" > help >
diff --git a/system/Config.in b/system/Config.in index 828df4217e..ed539dcbe0 100644 --- a/system/Config.in +++ b/system/Config.in @@ -3,11 +3,17 @@ menu "System configuration" choice prompt "Root FS skeleton" +# When not using an init system (i.e. a custom one), our default skeleton +# is most probably unfit; so, allow only the custom skeleton in that case. config BR2_ROOTFS_SKELETON_DEFAULT bool "default target skeleton" + depends on !BR2_INIT_NONE help Use default target skeleton +comment "default target skeleton needs an init system" + depends on BR2_INIT_NONE + config BR2_ROOTFS_SKELETON_CUSTOM bool "custom target skeleton" help