[v2] powerpc: allow compiling with GENERIC_MSI_IRQ_DOMAIN

Message ID 20170717131243.2157-1-laurentiu.tudor@nxp.com
State Accepted
Commit 8f36479d0eda3c078ee4e1ec79ea9a2650cd0996
Headers show

Commit Message

Laurentiu Tudor July 17, 2017, 1:12 p.m.
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

This allows building powerpc with the GENERIC_MSI_IRQ_DOMAIN
Kconfig by enabling the asm-generic msi.h in Kbuild. Without
this, there's a compilation error [1] because powerpc, as most
arches, doesn't provide an asm/msi.h.

[1] In file included from ./include/linux/kvm_host.h:20:0,
                 from ./arch/powerpc/include/asm/kvm_ppc.h:30,
                 from arch/powerpc/kernel/dbell.c:20:
./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
v2:
 - compilation error happens when GENERIC_MSI_IRQ_DOMAIN is enabled and not
   GENERIC_MSI_IRQ, so fix commit msg and title

previous version: https://patchwork.ozlabs.org/patch/782735/

 arch/powerpc/include/asm/Kbuild | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Ellerman July 18, 2017, 10:55 a.m. | #1
laurentiu.tudor@nxp.com writes:

> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> This allows building powerpc with the GENERIC_MSI_IRQ_DOMAIN
> Kconfig by enabling the asm-generic msi.h in Kbuild. Without
> this, there's a compilation error [1] because powerpc, as most
> arches, doesn't provide an asm/msi.h.
>
> [1] In file included from ./include/linux/kvm_host.h:20:0,
>                  from ./arch/powerpc/include/asm/kvm_ppc.h:30,
>                  from arch/powerpc/kernel/dbell.c:20:
> ./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory
>
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> ---
> v2:
>  - compilation error happens when GENERIC_MSI_IRQ_DOMAIN is enabled and not
>    GENERIC_MSI_IRQ, so fix commit msg and title

It looks like the only way powerpc can enable GENERIC_MSI_IRQ_DOMAIN is
by enabling FSL_MC_BUS ?

cheers
Laurentiu Tudor July 18, 2017, 11:06 a.m. | #2
Hi Michael,

On 07/18/2017 01:55 PM, Michael Ellerman wrote:
> laurentiu.tudor@nxp.com writes:
>
>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>>
>> This allows building powerpc with the GENERIC_MSI_IRQ_DOMAIN
>> Kconfig by enabling the asm-generic msi.h in Kbuild. Without
>> this, there's a compilation error [1] because powerpc, as most
>> arches, doesn't provide an asm/msi.h.
>>
>> [1] In file included from ./include/linux/kvm_host.h:20:0,
>>                   from ./arch/powerpc/include/asm/kvm_ppc.h:30,
>>                   from arch/powerpc/kernel/dbell.c:20:
>> ./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory
>>
>> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>> ---
>> v2:
>>   - compilation error happens when GENERIC_MSI_IRQ_DOMAIN is enabled and not
>>     GENERIC_MSI_IRQ, so fix commit msg and title
>
> It looks like the only way powerpc can enable GENERIC_MSI_IRQ_DOMAIN is
> by enabling FSL_MC_BUS ?
>

Yes, i think so. I'm currently working on making FSL_MC_BUS compile 
multi-arch [1] and that's how i hit this compilation error on ppc.

[1] https://lkml.org/lkml/2017/7/17/415

---
Best Regards, Laurentiu
Michael Ellerman July 27, 2017, 12:37 p.m. | #3
On Mon, 2017-07-17 at 13:12:43 UTC, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> 
> This allows building powerpc with the GENERIC_MSI_IRQ_DOMAIN
> Kconfig by enabling the asm-generic msi.h in Kbuild. Without
> this, there's a compilation error [1] because powerpc, as most
> arches, doesn't provide an asm/msi.h.
> 
> [1] In file included from ./include/linux/kvm_host.h:20:0,
>                  from ./arch/powerpc/include/asm/kvm_ppc.h:30,
>                  from arch/powerpc/kernel/dbell.c:20:
> ./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory
> 
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/8f36479d0eda3c078ee4e1ec79ea9a

cheers

Patch

diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 5c4fbc8..2542ea1 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -8,3 +8,4 @@  generic-y += mcs_spinlock.h
 generic-y += preempt.h
 generic-y += rwsem.h
 generic-y += vtime.h
+generic-y += msi.h