| Message ID | 1498839782-4702-2-git-send-email-pantelis.antoniou@konsulko.com |
|---|---|
| State | Deferred |
| Delegated to: | Simon Glass |
| Headers | show |
On 06/30/2017 06:22 PM, Pantelis Antoniou wrote: > Introduce FDT_PATH_MAX Because ... why ? The commit message is crap, please fix. > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > --- > lib/libfdt/libfdt.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/libfdt/libfdt.h b/lib/libfdt/libfdt.h > index 2f7ebf8..c369015 100644 > --- a/lib/libfdt/libfdt.h > +++ b/lib/libfdt/libfdt.h > @@ -100,6 +100,9 @@ > > #define FDT_ERR_MAX 18 > > +/* Maximum path size of a node (similar to PATH_MAX in *nix) */ > +#define FDT_PATH_MAX 4096 > + > /**********************************************************************/ > /* Low-level functions (you probably don't need these) */ > /**********************************************************************/ >
Hi, On 1 July 2017 at 08:01, Marek Vasut <marex@denx.de> wrote: > On 06/30/2017 06:22 PM, Pantelis Antoniou wrote: >> Introduce FDT_PATH_MAX > > Because ... why ? The commit message is crap, please fix. A better way of saying this is, please add a motivation to the commit message :-) Apart from that: Reviewed-by: Simon Glass <sjg@chromium.org> We can just pick it from upstream if it is applied there first. > >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> >> --- >> lib/libfdt/libfdt.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/libfdt/libfdt.h b/lib/libfdt/libfdt.h >> index 2f7ebf8..c369015 100644 >> --- a/lib/libfdt/libfdt.h >> +++ b/lib/libfdt/libfdt.h >> @@ -100,6 +100,9 @@ >> >> #define FDT_ERR_MAX 18 >> >> +/* Maximum path size of a node (similar to PATH_MAX in *nix) */ >> +#define FDT_PATH_MAX 4096 >> + >> /**********************************************************************/ >> /* Low-level functions (you probably don't need these) */ >> /**********************************************************************/ >> > > > -- > Best regards, > Marek Vasut Regards, Simon
Hi Simon, On Thu, 2017-07-06 at 21:58 -0600, Simon Glass wrote: > Hi, > > On 1 July 2017 at 08:01, Marek Vasut <marex@denx.de> wrote: > > On 06/30/2017 06:22 PM, Pantelis Antoniou wrote: > >> Introduce FDT_PATH_MAX > > > > Because ... why ? The commit message is crap, please fix. > > A better way of saying this is, please add a motivation to the commit > message :-) > Err, will do, but it's part of a patchset and it's so similar to what PATH_MAX does. Yeah I guess :) > Apart from that: > > Reviewed-by: Simon Glass <sjg@chromium.org> > > We can just pick it from upstream if it is applied there first. > Regards -- Pantelis > > > >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > >> --- > >> lib/libfdt/libfdt.h | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/lib/libfdt/libfdt.h b/lib/libfdt/libfdt.h > >> index 2f7ebf8..c369015 100644 > >> --- a/lib/libfdt/libfdt.h > >> +++ b/lib/libfdt/libfdt.h > >> @@ -100,6 +100,9 @@ > >> > >> #define FDT_ERR_MAX 18 > >> > >> +/* Maximum path size of a node (similar to PATH_MAX in *nix) */ > >> +#define FDT_PATH_MAX 4096 > >> + > >> /**********************************************************************/ > >> /* Low-level functions (you probably don't need these) */ > >> /**********************************************************************/ > >> > > > > > > -- > > Best regards, > > Marek Vasut > > Regards, > Simon
diff --git a/lib/libfdt/libfdt.h b/lib/libfdt/libfdt.h index 2f7ebf8..c369015 100644 --- a/lib/libfdt/libfdt.h +++ b/lib/libfdt/libfdt.h @@ -100,6 +100,9 @@ #define FDT_ERR_MAX 18 +/* Maximum path size of a node (similar to PATH_MAX in *nix) */ +#define FDT_PATH_MAX 4096 + /**********************************************************************/ /* Low-level functions (you probably don't need these) */ /**********************************************************************/
Introduce FDT_PATH_MAX Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> --- lib/libfdt/libfdt.h | 3 +++ 1 file changed, 3 insertions(+)