| Message ID | 1498201714-28060-6-git-send-email-daniel.meng@rock-chips.com |
|---|---|
| State | Superseded |
| Delegated to: | Philipp Tomsich |
| Headers | show |
> Use dev_read_bool() instead of fdt_getprop() to get the property > from DTS. And add a comment for "hnp-srp-disable" property to > fully describe its effect. > > Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> > --- > > Changes in v7: > - Romove unused variable ‘prop’ in dwc2 driver > > Changes in v6: > - New patch > - Use dev_read_bool() instead of fdt_getprop() > - Add a comment for "hnp-srp-disable" feature > > drivers/usb/host/dwc2.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Use dev_read_bool() instead of fdt_getprop() to get the property > from DTS. And add a comment for "hnp-srp-disable" property to > fully describe its effect. > > Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > Changes in v7: > - Romove unused variable ‘prop’ in dwc2 driver > > Changes in v6: > - New patch > - Use dev_read_bool() instead of fdt_getprop() > - Add a comment for "hnp-srp-disable" feature > > drivers/usb/host/dwc2.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c index 841e596..64c42ac 100644 --- a/drivers/usb/host/dwc2.c +++ b/drivers/usb/host/dwc2.c @@ -43,6 +43,10 @@ struct dwc2_priv { struct dwc2_core_regs *regs; int root_hub_devnum; bool ext_vbus; + /* + * The hnp/srp capability must be disabled if the platform + * does't support hnp/srp. Otherwise the force mode can't work. + */ bool hnp_srp_disable; bool oc_disable; }; @@ -1239,7 +1243,6 @@ static int dwc2_submit_int_msg(struct udevice *dev, struct usb_device *udev, static int dwc2_usb_ofdata_to_platdata(struct udevice *dev) { struct dwc2_priv *priv = dev_get_priv(dev); - const void *prop; fdt_addr_t addr; addr = devfdt_get_addr(dev); @@ -1247,15 +1250,8 @@ static int dwc2_usb_ofdata_to_platdata(struct udevice *dev) return -EINVAL; priv->regs = (struct dwc2_core_regs *)addr; - prop = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), - "disable-over-current", NULL); - if (prop) - priv->oc_disable = true; - - prop = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), - "hnp-srp-disable", NULL); - if (prop) - priv->hnp_srp_disable = true; + priv->oc_disable = dev_read_bool(dev, "disable-over-current"); + priv->hnp_srp_disable = dev_read_bool(dev, "hnp-srp-disable"); return 0; }
Use dev_read_bool() instead of fdt_getprop() to get the property from DTS. And add a comment for "hnp-srp-disable" property to fully describe its effect. Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> --- Changes in v7: - Romove unused variable ‘prop’ in dwc2 driver Changes in v6: - New patch - Use dev_read_bool() instead of fdt_getprop() - Add a comment for "hnp-srp-disable" feature drivers/usb/host/dwc2.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)