Bluetooth: btusb: Add support for 0489:e0a2 QCA_ROME device
diff mbox

Message ID 1498116284-20784-2-git-send-email-acelan.kao@canonical.com
State New
Headers show

Commit Message

AceLan Kao June 22, 2017, 7:24 a.m. UTC
From: "Shih-Yuan Lee (FourDollars)" <sylee@canonical.com>

T:  Bus=01 Lev=01 Prnt=01 Port=06 Cnt=03 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0489 ProdID=e0a2 Rev=00.01
C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
Suggested-by: Owen Lin <olin@rivetnetworks.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
(backported from commit 06e41d8a36689f465006f017bbcd8a73edb98109)
Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Colin King June 22, 2017, 7:51 a.m. UTC | #1
On 22/06/17 08:24, AceLan Kao wrote:
> From: "Shih-Yuan Lee (FourDollars)" <sylee@canonical.com>
> 
> T:  Bus=01 Lev=01 Prnt=01 Port=06 Cnt=03 Dev#=  3 Spd=12  MxCh= 0
> D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0489 ProdID=e0a2 Rev=00.01
> C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> 
> Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
> Suggested-by: Owen Lin <olin@rivetnetworks.com>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> (backported from commit 06e41d8a36689f465006f017bbcd8a73edb98109)
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 054de19..d4c38a8 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -255,6 +255,7 @@ static const struct usb_device_id blacklist_table[] = {
>  	{ USB_DEVICE(0x0cf3, 0xe009), .driver_info = BTUSB_QCA_ROME },
>  	{ USB_DEVICE(0x0cf3, 0xe300), .driver_info = BTUSB_QCA_ROME },
>  	{ USB_DEVICE(0x0cf3, 0xe360), .driver_info = BTUSB_QCA_ROME },
> +	{ USB_DEVICE(0x0489, 0xe0a2), .driver_info = BTUSB_QCA_ROME },
>  
>  	/* Broadcom BCM2035 */
>  	{ USB_DEVICE(0x0a5c, 0x2009), .driver_info = BTUSB_BCM92035 },
> 

Note: SRUs should also include details about the regression potential
too. If you can add SRU details you posted in the cover email to this
patch with the regression potential in the top of the bug then that
would be useful.

Since this is a minor blacklisting quirk that impacts just one specific
device the regression potential is very constrained.

Acked-by: Colin Ian King <colin.king@canonical.com>
Stefan Bader June 22, 2017, 8:07 a.m. UTC | #2
On 22.06.2017 09:24, AceLan Kao wrote:
> From: "Shih-Yuan Lee (FourDollars)" <sylee@canonical.com>
> 
> T:  Bus=01 Lev=01 Prnt=01 Port=06 Cnt=03 Dev#=  3 Spd=12  MxCh= 0
> D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0489 ProdID=e0a2 Rev=00.01
> C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> 
> Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
> Suggested-by: Owen Lin <olin@rivetnetworks.com>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> (backported from commit 06e41d8a36689f465006f017bbcd8a73edb98109)
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>

Acked-by: Stefan Bader <stefan.bader@canonical.com>

> ---

Again this patch has not BugLink info added to the patch. For future patches I
will start to NAK patches which miss this.

-Stefan
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 054de19..d4c38a8 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -255,6 +255,7 @@ static const struct usb_device_id blacklist_table[] = {
>  	{ USB_DEVICE(0x0cf3, 0xe009), .driver_info = BTUSB_QCA_ROME },
>  	{ USB_DEVICE(0x0cf3, 0xe300), .driver_info = BTUSB_QCA_ROME },
>  	{ USB_DEVICE(0x0cf3, 0xe360), .driver_info = BTUSB_QCA_ROME },
> +	{ USB_DEVICE(0x0489, 0xe0a2), .driver_info = BTUSB_QCA_ROME },
>  
>  	/* Broadcom BCM2035 */
>  	{ USB_DEVICE(0x0a5c, 0x2009), .driver_info = BTUSB_BCM92035 },
>

Patch
diff mbox

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 054de19..d4c38a8 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -255,6 +255,7 @@  static const struct usb_device_id blacklist_table[] = {
 	{ USB_DEVICE(0x0cf3, 0xe009), .driver_info = BTUSB_QCA_ROME },
 	{ USB_DEVICE(0x0cf3, 0xe300), .driver_info = BTUSB_QCA_ROME },
 	{ USB_DEVICE(0x0cf3, 0xe360), .driver_info = BTUSB_QCA_ROME },
+	{ USB_DEVICE(0x0489, 0xe0a2), .driver_info = BTUSB_QCA_ROME },
 
 	/* Broadcom BCM2035 */
 	{ USB_DEVICE(0x0a5c, 0x2009), .driver_info = BTUSB_BCM92035 },