diff mbox

[1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

Message ID 20170619132513.11518-1-thomas.claveirole@green-communications.fr
State Superseded
Headers show

Commit Message

Thomas Claveirole June 19, 2017, 1:25 p.m. UTC
fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
to build the package.  This is an issue when Buildroot supports a new
compiler version and this version makes some warnings appear.
Luckily, one can provide CFLAGS=-Wno-error to the configure script so
it appends -Wno-error to AM_CFLAGS.

Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
---
 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Baruch Siach June 19, 2017, 1:34 p.m. UTC | #1
Hi Thomas,

On Mon, Jun 19, 2017 at 03:25:13PM +0200, Thomas Claveirole wrote:
> fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
> to build the package.  This is an issue when Buildroot supports a new
> compiler version and this version makes some warnings appear.
> Luckily, one can provide CFLAGS=-Wno-error to the configure script so
> it appends -Wno-error to AM_CFLAGS.

Please add a reference to the autobuild failure:

http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

baruch

> Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
> ---
>  package/fcgiwrap/fcgiwrap.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/fcgiwrap/fcgiwrap.mk b/package/fcgiwrap/fcgiwrap.mk
> index dd74c1ef72..c080a1ae49 100644
> --- a/package/fcgiwrap/fcgiwrap.mk
> +++ b/package/fcgiwrap/fcgiwrap.mk
> @@ -10,6 +10,7 @@ FCGIWRAP_DEPENDENCIES = host-pkgconf libfcgi
>  FCGIWRAP_LICENSE = MIT
>  FCGIWRAP_LICENSE_FILES = COPYING
>  FCGIWRAP_AUTORECONF = YES
> +FCGIWRAP_CONF_OPTS += CFLAGS=-Wno-error
>  
>  ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>  FCGIWRAP_DEPENDENCIES += systemd
Thomas Claveirole June 19, 2017, 1:59 p.m. UTC | #2
Hi,

> Please add a reference to the autobuild failure:
>
> http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

Done, thanks.  I also forgot to mention $(TARGET_CFLAGS) when
overriding the CFLAGS for configure, this should be fixed now.

Thomas Claveirole (1):
  fcgiwrap: Disable -Werror in CFLAGS set by configure.

 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/package/fcgiwrap/fcgiwrap.mk b/package/fcgiwrap/fcgiwrap.mk
index dd74c1ef72..c080a1ae49 100644
--- a/package/fcgiwrap/fcgiwrap.mk
+++ b/package/fcgiwrap/fcgiwrap.mk
@@ -10,6 +10,7 @@  FCGIWRAP_DEPENDENCIES = host-pkgconf libfcgi
 FCGIWRAP_LICENSE = MIT
 FCGIWRAP_LICENSE_FILES = COPYING
 FCGIWRAP_AUTORECONF = YES
+FCGIWRAP_CONF_OPTS += CFLAGS=-Wno-error
 
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 FCGIWRAP_DEPENDENCIES += systemd