| Message ID | 7ce0e2734a7e95d3341c7424d124ddfd4bc82034.1497850925.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 516fa8d0e19d854253460ea7692551e836e7e2b5 |
| Headers | show |
On Mon, 2017-06-19 at 05:44:25 UTC, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by <linux/of.h> work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 407 576 0 983 3d7 drivers/macintosh/rack-meter.o > > File size after constify rackmeter_match. > text data bss dec hex filename > 807 176 0 983 3d7 drivers/macintosh/rack-meter.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/516fa8d0e19d854253460ea7692551 cheers
diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c index e199fd6..35582eb 100644 --- a/drivers/macintosh/rack-meter.c +++ b/drivers/macintosh/rack-meter.c @@ -579,7 +579,7 @@ static int rackmeter_shutdown(struct macio_dev* mdev) return 0; } -static struct of_device_id rackmeter_match[] = { +static const struct of_device_id rackmeter_match[] = { { .name = "i2s" }, { } };
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by <linux/of.h> work with const of_device_ids. So mark the non-const structs as const. File size before: text data bss dec hex filename 407 576 0 983 3d7 drivers/macintosh/rack-meter.o File size after constify rackmeter_match. text data bss dec hex filename 807 176 0 983 3d7 drivers/macintosh/rack-meter.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- Changes in v1: Subject was wrong. It should be constify rackmeter_match. drivers/macintosh/rack-meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)