diff mbox

qemu-doc: include version number

Message ID 20170606151919.772-1-pbonzini@redhat.com
State New
Headers show

Commit Message

Paolo Bonzini June 6, 2017, 3:19 p.m. UTC
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu-doc.texi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Peter Maydell June 6, 2017, 3:25 p.m. UTC | #1
On 6 June 2017 at 16:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-doc.texi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 965ba5929e..8e5c4a951f 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -1,6 +1,7 @@
>  \input texinfo @c -*- texinfo -*-
>  @c %**start of header
>  @setfilename qemu-doc.info
> +@include version.texi
>
>  @documentlanguage en
>  @documentencoding UTF-8
> @@ -19,7 +20,7 @@
>  @iftex
>  @titlepage
>  @sp 7
> -@center @titlefont{QEMU Emulator}
> +@center @titlefont{QEMU version @value{VERSION}}
>  @sp 1
>  @center @titlefont{User Documentation}
>  @sp 3
> --
> 2.13.0

I think you also now need to make the qemu-doc.* files depend
on version.texi (as we do already for qemu-ga-ref.* and qemu-qmp-ref.*)
(If we plan to make the other docs also use version.texi, this
might be best done by reverting some of commit bd7f97479687.)

thanks
-- PMM
Paolo Bonzini June 6, 2017, 3:38 p.m. UTC | #2
On 06/06/2017 17:25, Peter Maydell wrote:
> On 6 June 2017 at 16:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  qemu-doc.texi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 965ba5929e..8e5c4a951f 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -1,6 +1,7 @@
>>  \input texinfo @c -*- texinfo -*-
>>  @c %**start of header
>>  @setfilename qemu-doc.info
>> +@include version.texi
>>
>>  @documentlanguage en
>>  @documentencoding UTF-8
>> @@ -19,7 +20,7 @@
>>  @iftex
>>  @titlepage
>>  @sp 7
>> -@center @titlefont{QEMU Emulator}
>> +@center @titlefont{QEMU version @value{VERSION}}
>>  @sp 1
>>  @center @titlefont{User Documentation}
>>  @sp 3
>> --
>> 2.13.0
> 
> I think you also now need to make the qemu-doc.* files depend
> on version.texi (as we do already for qemu-ga-ref.* and qemu-qmp-ref.*)
> (If we plan to make the other docs also use version.texi, this
> might be best done by reverting some of commit bd7f97479687.)

Indeed, so I'll make a two-patch series with this and  "docs: create
interop/ subdirectory".

Paolo
diff mbox

Patch

diff --git a/qemu-doc.texi b/qemu-doc.texi
index 965ba5929e..8e5c4a951f 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -1,6 +1,7 @@ 
 \input texinfo @c -*- texinfo -*-
 @c %**start of header
 @setfilename qemu-doc.info
+@include version.texi
 
 @documentlanguage en
 @documentencoding UTF-8
@@ -19,7 +20,7 @@ 
 @iftex
 @titlepage
 @sp 7
-@center @titlefont{QEMU Emulator}
+@center @titlefont{QEMU version @value{VERSION}}
 @sp 1
 @center @titlefont{User Documentation}
 @sp 3