diff mbox

[U-Boot,2/4] rockchip: arm64: rk3399: support DDR3-1866 (i.e. 933MHz clock)

Message ID 1496247397-744-2-git-send-email-philipp.tomsich@theobroma-systems.com
State Accepted
Commit fcb21585169c0bf800a143ceb1b91a323c9d1261
Delegated to: Simon Glass
Headers show

Commit Message

Philipp Tomsich May 31, 2017, 4:16 p.m. UTC
The RK3399 is capable of driving DDR3 at 933MHz (i.e. DDR3-1866),
if the PCB layout permits and appropriate memory timings are used.

This changes the sanity checks to allow a DTS to request DDR3-1866
operation.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com>
---

 arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass June 2, 2017, 2:55 a.m. UTC | #1
On 31 May 2017 at 10:16, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> The RK3399 is capable of driving DDR3 at 933MHz (i.e. DDR3-1866),
> if the PCB layout permits and appropriate memory timings are used.
>
> This changes the sanity checks to allow a DTS to request DDR3-1866
> operation.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com>
> ---
>
>  arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Kever Yang June 2, 2017, 3:01 a.m. UTC | #2
Philipp,


On 06/01/2017 12:16 AM, Philipp Tomsich wrote:
> The RK3399 is capable of driving DDR3 at 933MHz (i.e. DDR3-1866),
> if the PCB layout permits and appropriate memory timings are used.
>
> This changes the sanity checks to allow a DTS to request DDR3-1866
> operation.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
>   arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c b/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c
> index 4dd84e2..0b87fcf 100644
> --- a/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c
> +++ b/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c
> @@ -1090,7 +1090,7 @@ static int sdram_init(struct dram_info *dram,
>   
>   	debug("Starting SDRAM initialization...\n");
>   
> -	if ((dramtype == DDR3 && ddr_freq > 800) ||
> +	if ((dramtype == DDR3 && ddr_freq > 933) ||
>   	    (dramtype == LPDDR3 && ddr_freq > 933) ||
>   	    (dramtype == LPDDR4 && ddr_freq > 800)) {
>   		debug("SDRAM frequency is to high!");
Simon Glass June 5, 2017, 9:31 p.m. UTC | #3
Philipp,


On 06/01/2017 12:16 AM, Philipp Tomsich wrote:
> The RK3399 is capable of driving DDR3 at 933MHz (i.e. DDR3-1866),
> if the PCB layout permits and appropriate memory timings are used.
>
> This changes the sanity checks to allow a DTS to request DDR3-1866
> operation.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
>   arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c b/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c
index 4dd84e2..0b87fcf 100644
--- a/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c
+++ b/arch/arm/mach-rockchip/rk3399/sdram_rk3399.c
@@ -1090,7 +1090,7 @@  static int sdram_init(struct dram_info *dram,
 
 	debug("Starting SDRAM initialization...\n");
 
-	if ((dramtype == DDR3 && ddr_freq > 800) ||
+	if ((dramtype == DDR3 && ddr_freq > 933) ||
 	    (dramtype == LPDDR3 && ddr_freq > 933) ||
 	    (dramtype == LPDDR4 && ddr_freq > 800)) {
 		debug("SDRAM frequency is to high!");