| Message ID | df836592-de5b-346b-8738-853c3d726567@kernel.org |
|---|---|
| State | Not Applicable |
| Delegated to: | Marek Vasut |
| Headers | show |
On Kha, 2017-05-25 at 08:35 -0500, Dinh Nguyen wrote: > > On 05/25/2017 03:53 AM, Chee, Tien Fong wrote: > > > > On Rab, 2017-05-24 at 09:56 -0500, Dinh Nguyen wrote: > > > > > > > > > On 05/23/2017 09:24 PM, tien.fong.chee@intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > This is the 6th version of patchset to adds support for Intel > > > > Arria > > > > 10 SoC FPGA > > > > driver. This version mainly resolved comments from Dinh in > > > > [v5]. > > > > This series is working on top of u-boot-socfpga-next branch > > > > http://git.denx.de/?p=u-boot/u-boot-socfpga.git;a=shortlog;h=re > > > > fs/h > > > > eads/next. > > > > > > > > [v5]: https://www.mail-archive.com/u-boot@lists.denx.de/msg2505 > > > > 17.h > > > > tml > > > > > > > > v5 -> v6 changes: > > > > ----------------- > > > > - Created separate patch for enabling FPGA driver support. > > > > > > > Please consider at least doing a compile test for this patch > > > series? > > > I'm > > > now very skeptical that you've done any kind of testing on this > > > patch > > > series? :( > > > > > > For 'make socfpga_cyclone5_defconfig: > > > > > > arch/arm/mach-socfpga/built-in.o: In function > > > `socfpga_bridges_reset': > > > /home/dinguyen/linux_dev/u-boot/arch/arm/mach- > > > socfpga/reset_manager_gen5.c:101: > > > undefined reference to `fpgamgr_test_fpga_ready' > > > arch/arm/mach-socfpga/built-in.o: In function > > > `populate_sysmgr_fpgaintf_module': > > > /home/dinguyen/linux_dev/u-boot/arch/arm/mach- > > > socfpga/system_manager_gen5.c:48: > > > undefined reference to `fpgamgr_test_fpga_ready' > > > drivers/built-in.o: In function `sdram_mmr_init_full': > > > /home/dinguyen/linux_dev/u-boot/drivers/ddr/altera/sdram.c:448: > > > undefined reference to `fpgamgr_test_fpga_ready' > > > scripts/Makefile.spl:334: recipe for target 'spl/u-boot-spl' > > > failed > > > make[1]: *** [spl/u-boot-spl] Error 1 > > > Makefile:1347: recipe for target 'spl/u-boot-spl' failed > > > make: *** [spl/u-boot-spl] Error 2 > > > > > > For socfpga_arria10_defconfig: > > > > > > arch/arm/mach-socfpga/built-in.o: In function `socfpga_fpga_add': > > > /home/dinguyen/linux_dev/u-boot/arch/arm/mach-socfpga/misc.c:110: > > > undefined reference to `fpga_init' > > > /home/dinguyen/linux_dev/u-boot/arch/arm/mach-socfpga/misc.c:112: > > > undefined reference to `fpga_add' > > > scripts/Makefile.spl:334: recipe for target 'spl/u-boot-spl' > > > failed > > > make[1]: *** [spl/u-boot-spl] Error 1 > > > Makefile:1347: recipe for target 'spl/u-boot-spl' failed > > > make: *** [spl/u-boot-spl] Error 2 > > > > > > > > > Dinh > > I did the compilation on each patch, and testing the patch set on > > all > > arria10, cyclone5 and arria10 devkit. > > > > I suspect something wrong with v6-0005-arm-socfpga-Move-FPGA- > > manager- > > driver-to-FPGA-driv.patch you applied. Could you help me check > > again > > and confirm all the patches waere applied properly? > > > Yes, I've applied all of your patches correctly. The only diff > between > this series and the last is: > > $ git diff tien_fong_fpga_a10_v5 > diff --git a/drivers/Makefile b/drivers/Makefile > index b4a2230..4a4b237 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -47,7 +47,6 @@ obj-$(CONFIG_OMAP_USB_PHY) += usb/phy/ > obj-$(CONFIG_SPL_SATA_SUPPORT) += block/ > obj-$(CONFIG_SPL_USB_HOST_SUPPORT) += block/ > obj-$(CONFIG_SPL_MMC_SUPPORT) += block/ > -obj-$(CONFIG_FPGA) += fpga/ > endif > > ifdef CONFIG_TPL_BUILD > diff --git a/include/configs/socfpga_common.h > b/include/configs/socfpga_common.h > index 913b9f1..9edcd2d 100644 > --- a/include/configs/socfpga_common.h > +++ b/include/configs/socfpga_common.h > @@ -109,6 +109,7 @@ > #define CONFIG_FPGA > #define CONFIG_FPGA_ALTERA > #define CONFIG_FPGA_SOCFPGA > +#define CONFIG_SPL_FPGA_SUPPORT > #define CONFIG_FPGA_COUNT 1 > #endif > > So the patch for using CONFIG_SPL_FPGA_SUPPORT is causing this build > error. Please investigate. > > Dinh Hi Dinh, I have tried with both u-boot.git and u-boot-socfpga.git lastest version, i can't still reproduce the issue u have seen :(. Would you mind to share me the details of the step to reproduce it such as on what branch? Hi Ley Foon, Could you help to try out the patch set too? Thanks a lot. Fong.
On 05/26/2017 03:48 AM, Chee, Tien Fong wrote: >> >> So the patch for using CONFIG_SPL_FPGA_SUPPORT is causing this build >> error. Please investigate. >> >> Dinh > > Hi Dinh, > > I have tried with both u-boot.git and u-boot-socfpga.git lastest > version, i can't still reproduce the issue u have seen :(. Would you > mind to share me the details of the step to reproduce it such as on > what branch? > Ah, sorry about that. I went back and just did a batch apply of all 6 patches, and it builds fine. I was hitting the build error because I missed applying patch 4/6 "arm: socfpga: Enable FPGA driver build on SPL" The reason I missed this was because the 3/6 patch was named "arm: socfpga: Enable FPGA driver on SPL". So can you please go back and edit the commit header of patch 4/6, to something more generic? As its not ARM or SOCFPGA specific. Thanks, Dinh
On Jum, 2017-05-26 at 09:49 -0500, Dinh Nguyen wrote: > > On 05/26/2017 03:48 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > So the patch for using CONFIG_SPL_FPGA_SUPPORT is causing this > > > build > > > error. Please investigate. > > > > > > Dinh > > Hi Dinh, > > > > I have tried with both u-boot.git and u-boot-socfpga.git lastest > > version, i can't still reproduce the issue u have seen :(. Would > > you > > mind to share me the details of the step to reproduce it such as on > > what branch? > > > Ah, sorry about that. I went back and just did a batch apply of all 6 > patches, and it builds fine. > > I was hitting the build error because I missed applying patch 4/6 > "arm: > socfpga: Enable FPGA driver build on SPL" > > The reason I missed this was because the 3/6 patch was named "arm: > socfpga: Enable FPGA driver on SPL". > > So can you please go back and edit the commit header of patch 4/6, to > something more generic? As its not ARM or SOCFPGA specific. > > Thanks, > Dinh great, at least we know what going on. Yeah, i can change that to more generic. Thanks.
diff --git a/drivers/Makefile b/drivers/Makefile index b4a2230..4a4b237 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -47,7 +47,6 @@ obj-$(CONFIG_OMAP_USB_PHY) += usb/phy/ obj-$(CONFIG_SPL_SATA_SUPPORT) += block/ obj-$(CONFIG_SPL_USB_HOST_SUPPORT) += block/ obj-$(CONFIG_SPL_MMC_SUPPORT) += block/ -obj-$(CONFIG_FPGA) += fpga/ endif ifdef CONFIG_TPL_BUILD diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 913b9f1..9edcd2d 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -109,6 +109,7 @@ #define CONFIG_FPGA #define CONFIG_FPGA_ALTERA #define CONFIG_FPGA_SOCFPGA +#define CONFIG_SPL_FPGA_SUPPORT #define CONFIG_FPGA_COUNT 1 #endif