Message ID | 4D10A473.2030202@monstr.eu |
---|---|
State | Superseded |
Headers | show |
Dear Michal Simek, In message <4D10A473.2030202@monstr.eu> you wrote: > > I would like to do it but it is not easy to use sizeof because there are > some dependencies in macros in common.h(lines 193-201) because I am > using CONFIG_SYS_GBL_DATA_OFFSET for monitor/malloc areas. > > The best will be to be able to generate this value in lib/asm-offsets.c > > Not sure if you are ok with it. Yes, this is OK. > diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c > index 2209561..36fc198 100644 > --- a/lib/asm-offsets.c > +++ b/lib/asm-offsets.c > @@ -24,6 +24,8 @@ int main(void) > /* Round up to make sure size gives nice stack alignment */ > DEFINE(GENERATED_GBL_DATA_SIZE, > (sizeof(struct global_data)+15) & ~15); > + DEFINE(GENERATED_BD_INFO_SIZE, > + (sizeof(struct bd_info)+15) & ~15); > > return 0; > } This patch is white-space corrupted, though. Best regards, Wolfgang Denk
Wolfgang Denk wrote: > Dear Michal Simek, > > In message <4D10A473.2030202@monstr.eu> you wrote: >> I would like to do it but it is not easy to use sizeof because there are >> some dependencies in macros in common.h(lines 193-201) because I am >> using CONFIG_SYS_GBL_DATA_OFFSET for monitor/malloc areas. >> >> The best will be to be able to generate this value in lib/asm-offsets.c >> >> Not sure if you are ok with it. > > Yes, this is OK. > >> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c >> index 2209561..36fc198 100644 >> --- a/lib/asm-offsets.c >> +++ b/lib/asm-offsets.c >> @@ -24,6 +24,8 @@ int main(void) >> /* Round up to make sure size gives nice stack alignment */ >> DEFINE(GENERATED_GBL_DATA_SIZE, >> (sizeof(struct global_data)+15) & ~15); >> + DEFINE(GENERATED_BD_INFO_SIZE, >> + (sizeof(struct bd_info)+15) & ~15); >> >> return 0; >> } > > This patch is white-space corrupted, though. It wasn't intended as a patch just show if this approach will be acceptable. I will generate patches based on this. Thanks, Michal
diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c index 2209561..36fc198 100644 --- a/lib/asm-offsets.c +++ b/lib/asm-offsets.c @@ -24,6 +24,8 @@ int main(void) /* Round up to make sure size gives nice stack alignment */ DEFINE(GENERATED_GBL_DATA_SIZE, (sizeof(struct global_data)+15) & ~15); + DEFINE(GENERATED_BD_INFO_SIZE, + (sizeof(struct bd_info)+15) & ~15); return 0; }