diff mbox

[U-Boot,1/1] net/arp: remove superfluous assignments

Message ID 20170508192428.30063-1-xypron.glpk@gmx.de
State Accepted
Commit 8cfb77387eb2923ec566617ff46762010859525f
Delegated to: Tom Rini
Headers show

Commit Message

Heinrich Schuchardt May 8, 2017, 7:24 p.m. UTC 
The value of variable pkt is never used.

The problem was indicated by clang scan-build.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 net/arp.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Tom Rini May 12, 2017, 5:21 p.m. UTC | #1 
On Mon, May 08, 2017 at 09:24:28PM +0200, xypron.glpk@gmx.de wrote:

> The value of variable pkt is never used.
> 
> The problem was indicated by clang scan-build.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/net/arp.c b/net/arp.c
index 824d2e9393..f3ceff9ed8 100644
--- a/net/arp.c
+++ b/net/arp.c
@@ -125,7 +125,6 @@  void arp_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len)
 {
 	struct arp_hdr *arp;
 	struct in_addr reply_ip_addr;
-	uchar *pkt;
 	int eth_hdr_size;
 
 	/*
@@ -163,9 +162,7 @@  void arp_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len)
 	case ARPOP_REQUEST:
 		/* reply with our IP address */
 		debug_cond(DEBUG_DEV_PKT, "Got ARP REQUEST, return our IP\n");
-		pkt = (uchar *)et;
 		eth_hdr_size = net_update_ether(et, et->et_src, PROT_ARP);
-		pkt += eth_hdr_size;
 		arp->ar_op = htons(ARPOP_REPLY);
 		memcpy(&arp->ar_tha, &arp->ar_sha, ARP_HLEN);
 		net_copy_ip(&arp->ar_tpa, &arp->ar_spa);