diff mbox

[U-Boot,v2] drivers: spi: Remove duplicate .probe method

Message ID 1493792249-4187-1-git-send-email-suniel.spartan@gmail.com
State Accepted
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Suniel Mahesh May 3, 2017, 6:17 a.m. UTC 
From: Suniel Mahesh <suniel.spartan@gmail.com>

.probe method has been assigned twice when declaring
a driver with U_BOOT_DRIVER(). Removed one of them.
Here is the last commit which had the duplicate entry:
"spi: omap3: Convert to driver model"
(sha1: 77b8d04854f486741471ad02b93b473b5b3d72f8)

Signed-off-by: Suniel Mahesh <suniel.spartan@gmail.com>
---
Note:
Tested on latest u-boot mainline tree and maintainers u-boot-spi
tree, no build issues.
---
Changes for v2:
Modified commit message to include details of the last commit
which had the duplicate entry, as suggested by Jagan Teki
---
 drivers/spi/omap3_spi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jagan Teki May 3, 2017, 6:23 a.m. UTC | #1 
On Wed, May 3, 2017 at 11:47 AM,  <suniel.spartan@gmail.com> wrote:
> From: Suniel Mahesh <suniel.spartan@gmail.com>
>
> .probe method has been assigned twice when declaring
> a driver with U_BOOT_DRIVER(). Removed one of them.
> Here is the last commit which had the duplicate entry:
> "spi: omap3: Convert to driver model"
> (sha1: 77b8d04854f486741471ad02b93b473b5b3d72f8)

Applied to u-boot-spi/master

thanks!
diff mbox

Patch

diff --git a/drivers/spi/omap3_spi.c b/drivers/spi/omap3_spi.c
index 8a89450..76d376a 100644
--- a/drivers/spi/omap3_spi.c
+++ b/drivers/spi/omap3_spi.c
@@ -692,6 +692,5 @@  U_BOOT_DRIVER(omap3_spi) = {
 	.probe = omap3_spi_probe,
 	.ops    = &omap3_spi_ops,
 	.priv_auto_alloc_size = sizeof(struct omap3_spi_priv),
-	.probe = omap3_spi_probe,
 };
 #endif