diff mbox

[v5,4/9] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter

Message ID 1493628599-30552-5-git-send-email-preid@electromag.com.au
State Superseded
Headers show

Commit Message

Phil Reid May 1, 2017, 8:49 a.m. UTC
Add a call to of_i2c_setup_smbus_alert when a i2c adapter is registered
so the the smbalert driver can be registered.

Signed-off-by: Phil Reid <preid@electromag.com.au>
---
 drivers/i2c/i2c-core.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

kernel test robot May 2, 2017, 5:42 p.m. UTC | #1
Hi Phil,

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.11 next-20170501]
[cannot apply to wsa/i2c/for-next battery/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Phil-Reid/Add-sbs-manager-with-smbalert-support/20170501-170247
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/built-in.o: In function `nsp_usb3_phy_init':
   binder.c:(.text+0x13744): undefined reference to `mdiobus_write'
   binder.c:(.text+0x13760): undefined reference to `mdiobus_write'
   binder.c:(.text+0x1377c): undefined reference to `mdiobus_write'
   binder.c:(.text+0x13798): undefined reference to `mdiobus_write'
   binder.c:(.text+0x137b4): undefined reference to `mdiobus_write'
   drivers/built-in.o:binder.c:(.text+0x137e8): more undefined references to `mdiobus_write' follow
   drivers/built-in.o: In function `i2c_register_adapter':
>> binder.c:(.text+0x21646c): undefined reference to `of_i2c_setup_smbus_alert'
   drivers/built-in.o: In function `mdio_module_init':
   binder.c:(.init.text+0x7dd4): undefined reference to `mdio_driver_register'
   drivers/built-in.o: In function `mdio_module_exit':
   binder.c:(.exit.text+0x19c): undefined reference to `mdio_driver_unregister'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index d2402bb..626471b 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -40,6 +40,7 @@ 
 #include <linux/gpio.h>
 #include <linux/hardirq.h>
 #include <linux/i2c.h>
+#include <linux/i2c-smbus.h>
 #include <linux/idr.h>
 #include <linux/init.h>
 #include <linux/irqflags.h>
@@ -2045,6 +2046,9 @@  static int i2c_register_adapter(struct i2c_adapter *adap)
 		dev_warn(&adap->dev,
 			 "Failed to create compatibility class link\n");
 #endif
+	res = of_i2c_setup_smbus_alert(adap);
+	if (res)
+		goto out_list;
 
 	i2c_init_recovery(adap);