| Message ID | 1492607344-63856-1-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Apr 19, 2017 at 03:09:04PM +0200, Philipp Tomsich wrote: > An assignment (of a value to itself) was left over (after removing and > addition from the line) from moving the common padding code into > rkcommon_vrec_header. > > This change removes this to avoid a spurious warning in static code > analysis (i.e. Coverity). > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Reported-by: Coverity (CID: 161418) Reviewed-by: Tom Rini <trini@konsulko.com> Thanks!
On Wed, Apr 19, 2017 at 03:09:04PM +0200, Philipp Tomsich wrote: > An assignment (of a value to itself) was left over (after removing and > addition from the line) from moving the common padding code into > rkcommon_vrec_header. > > This change removes this to avoid a spurious warning in static code > analysis (i.e. Coverity). > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Reported-by: Coverity (CID: 161418) > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 1316b9a..f4d932b 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -376,7 +376,6 @@ int rkcommon_vrec_header(struct image_tool_params *params, /* Allocate, clear and install the header */ tparams->hdr = malloc(tparams->header_size); memset(tparams->hdr, 0, tparams->header_size); - tparams->header_size = tparams->header_size; /* * If someone passed in 0 for the alignment, we'd better handle
An assignment (of a value to itself) was left over (after removing and addition from the line) from moving the common padding code into rkcommon_vrec_header. This change removes this to avoid a spurious warning in static code analysis (i.e. Coverity). Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- tools/rkcommon.c | 1 - 1 file changed, 1 deletion(-)