diff mbox

[U-Boot,1/2] include: config: am335x: disable DM_MMC_OPS if DM_MMC is disabled

Message ID 1492192202-32550-2-git-send-email-jjhiblot@ti.com
State Accepted
Delegated to: Jaehoon Chung
Headers show

Commit Message

Jean-Jacques Hiblot April 14, 2017, 5:50 p.m. UTC
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
 include/configs/am335x_evm.h | 1 +
 include/configs/am335x_shc.h | 1 +
 include/configs/chiliboard.h | 1 +
 3 files changed, 3 insertions(+)

Comments

Simon Glass April 16, 2017, 7:33 p.m. UTC | #1
Hi,

On 14 April 2017 at 11:50, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
>  include/configs/am335x_evm.h | 1 +
>  include/configs/am335x_shc.h | 1 +
>  include/configs/chiliboard.h | 1 +
>  3 files changed, 3 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

This seems unfortunate. Is there not enough space in SPL?
Jean-Jacques Hiblot April 18, 2017, 8:24 a.m. UTC | #2
On 16/04/2017 21:33, Simon Glass wrote:
> Hi,
>
> On 14 April 2017 at 11:50, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> ---
>>   include/configs/am335x_evm.h | 1 +
>>   include/configs/am335x_shc.h | 1 +
>>   include/configs/chiliboard.h | 1 +
>>   3 files changed, 3 insertions(+)
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> This seems unfortunate. Is there not enough space in SPL?*
I guess it would work. It adds about 11kB to the MLO. I'll do the test 
on a am335x evm but won't be able to test on the other two platforms.
>
Jaehoon Chung April 21, 2017, 8:10 a.m. UTC | #3
Hi,

On 04/15/2017 02:50 AM, Jean-Jacques Hiblot wrote:
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> ---
>  include/configs/am335x_evm.h | 1 +
>  include/configs/am335x_shc.h | 1 +
>  include/configs/chiliboard.h | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
> index 2712687..d7787a1 100644
> --- a/include/configs/am335x_evm.h
> +++ b/include/configs/am335x_evm.h
> @@ -284,6 +284,7 @@
>   */
>  #ifdef CONFIG_SPL_BUILD
>  #undef CONFIG_DM_MMC
> +#undef CONFIG_DM_MMC_OPS
>  #undef CONFIG_TIMER
>  #undef CONFIG_DM_USB
>  #endif
> diff --git a/include/configs/am335x_shc.h b/include/configs/am335x_shc.h
> index c100fbc..2f35a2c 100644
> --- a/include/configs/am335x_shc.h
> +++ b/include/configs/am335x_shc.h
> @@ -262,6 +262,7 @@
>   */
>  #ifdef CONFIG_SPL_BUILD
>  #undef CONFIG_DM_MMC
> +#undef CONFIG_DM_MMC_OPS
>  #undef CONFIG_TIMER
>  #endif
>  
> diff --git a/include/configs/chiliboard.h b/include/configs/chiliboard.h
> index c1669fa..0577c57 100644
> --- a/include/configs/chiliboard.h
> +++ b/include/configs/chiliboard.h
> @@ -188,6 +188,7 @@
>   */
>  #ifdef CONFIG_SPL_BUILD
>  #undef CONFIG_DM_MMC
> +#undef CONFIG_DM_MMC_OPS
>  #undef CONFIG_TIMER
>  #undef CONFIG_DM_USB
>  #endif
>
diff mbox

Patch

diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index 2712687..d7787a1 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -284,6 +284,7 @@ 
  */
 #ifdef CONFIG_SPL_BUILD
 #undef CONFIG_DM_MMC
+#undef CONFIG_DM_MMC_OPS
 #undef CONFIG_TIMER
 #undef CONFIG_DM_USB
 #endif
diff --git a/include/configs/am335x_shc.h b/include/configs/am335x_shc.h
index c100fbc..2f35a2c 100644
--- a/include/configs/am335x_shc.h
+++ b/include/configs/am335x_shc.h
@@ -262,6 +262,7 @@ 
  */
 #ifdef CONFIG_SPL_BUILD
 #undef CONFIG_DM_MMC
+#undef CONFIG_DM_MMC_OPS
 #undef CONFIG_TIMER
 #endif
 
diff --git a/include/configs/chiliboard.h b/include/configs/chiliboard.h
index c1669fa..0577c57 100644
--- a/include/configs/chiliboard.h
+++ b/include/configs/chiliboard.h
@@ -188,6 +188,7 @@ 
  */
 #ifdef CONFIG_SPL_BUILD
 #undef CONFIG_DM_MMC
+#undef CONFIG_DM_MMC_OPS
 #undef CONFIG_TIMER
 #undef CONFIG_DM_USB
 #endif