diff mbox

[U-Boot,V2,07/12] spi: kconfig: add soft spi Kconfig entry

Message ID 1492063800-17290-7-git-send-email-peng.fan@nxp.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Peng Fan April 13, 2017, 6:09 a.m. UTC
Add the Kconfig entry for SOFT_SPI which uses gpio to simulate the
SPI signals. We use it for accessing 74x164 on some i.MX boards.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Jagan Teki <jagan@openedev.com>
Cc: Stefano Babic <sbabic@denx.de>
---

V2:
 None

 drivers/spi/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jagan Teki May 3, 2017, 6:06 a.m. UTC | #1
On Thu, Apr 13, 2017 at 11:39 AM, Peng Fan <peng.fan@nxp.com> wrote:
> Add the Kconfig entry for SOFT_SPI which uses gpio to simulate the
> SPI signals. We use it for accessing 74x164 on some i.MX boards.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Jagan Teki <jagan@openedev.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>
> V2:
>  None
>
>  drivers/spi/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f3f7dbe..bef864f 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -197,6 +197,12 @@ config OMAP3_SPI
>
>  endif # if DM_SPI
>
> +config SOFT_SPI
> +       bool "Soft SPI driver"

Did you move this for dm-driven file? since we've two files with same config

> +       help
> +        Enable Soft SPI driver. This driver is to use GPIO simulate
> +        the SPI protocol.

If possible please write few lines about this

thanks!
Peng Fan May 8, 2017, 2:47 a.m. UTC | #2
On Wed, May 03, 2017 at 11:36:06AM +0530, Jagan Teki wrote:
>On Thu, Apr 13, 2017 at 11:39 AM, Peng Fan <peng.fan@nxp.com> wrote:
>> Add the Kconfig entry for SOFT_SPI which uses gpio to simulate the
>> SPI signals. We use it for accessing 74x164 on some i.MX boards.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Jagan Teki <jagan@openedev.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>>
>> V2:
>>  None
>>
>>  drivers/spi/Kconfig | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
>> index f3f7dbe..bef864f 100644
>> --- a/drivers/spi/Kconfig
>> +++ b/drivers/spi/Kconfig
>> @@ -197,6 +197,12 @@ config OMAP3_SPI
>>
>>  endif # if DM_SPI
>>
>> +config SOFT_SPI
>> +       bool "Soft SPI driver"
>
>Did you move this for dm-driven file? since we've two files with same config

This config is for dm and non-dm both.

>
>> +       help
>> +        Enable Soft SPI driver. This driver is to use GPIO simulate
>> +        the SPI protocol.
>
>If possible please write few lines about this

I understand this two line help message will trigger check patch warning,
but I think this is clear to tell user what this option is.

Thanks,
Peng.

>
>thanks!
>-- 
>Jagan Teki
>Free Software Engineer | www.openedev.com
>U-Boot, Linux | Upstream Maintainer
>Hyderabad, India.
>_______________________________________________
>U-Boot mailing list
>U-Boot@lists.denx.de
>https://lists.denx.de/listinfo/u-boot
diff mbox

Patch

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f3f7dbe..bef864f 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -197,6 +197,12 @@  config OMAP3_SPI
 
 endif # if DM_SPI
 
+config SOFT_SPI
+	bool "Soft SPI driver"
+	help
+	 Enable Soft SPI driver. This driver is to use GPIO simulate
+	 the SPI protocol.
+
 config FSL_ESPI
 	bool "Freescale eSPI driver"
 	help