| Message ID | 20170401224812.11646-1-iwamatsu@nigauri.org |
|---|---|
| State | Accepted |
| Commit | fad6a2b771eecac5ce69173235743e5357bf014d |
| Delegated to: | Tom Rini |
| Headers | show |
Dear Nobuhiro, In message <20170401224812.11646-1-iwamatsu@nigauri.org> you wrote: > The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal, > but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number > from hexadecimal to integer. ... > - default 4096 > + default 0x1000 > help > This should be large enough to hold the bootstage stash. A value of > 4096 (4KiB) is normally plenty. Would it make sense to also fix the help message, and maybe even to add a note to the help message that this should be a hex number? Thanks. Wolfgang Denk
On Sun, Apr 02, 2017 at 11:22:42AM +0200, Wolfgang Denk wrote: > Dear Nobuhiro, > > In message <20170401224812.11646-1-iwamatsu@nigauri.org> you wrote: > > The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal, > > but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number > > from hexadecimal to integer. > ... > > - default 4096 > > + default 0x1000 > > help > > This should be large enough to hold the bootstage stash. A value of > > 4096 (4KiB) is normally plenty. > > Would it make sense to also fix the help message, and maybe even to > add a note to the help message that this should be a hex number? Yes, perhaps s/4096/0x1000/ in the help message will be clear enough since Kconfig tooling will take care of saying "THIS IS HEX!" somwwhere relevant. Thanks!
On Sun, Apr 02, 2017 at 07:48:12AM +0900, Nobuhiro Iwamatsu wrote: > The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal, > but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number > from hexadecimal to integer. > > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> Applied to u-boot/master, thanks!
diff --git a/common/Kconfig b/common/Kconfig index 8f73c8f757..fe5bb69409 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -90,7 +90,7 @@ config BOOTSTAGE_STASH_ADDR config BOOTSTAGE_STASH_SIZE hex "Size of boot timing stash region" - default 4096 + default 0x1000 help This should be large enough to hold the bootstage stash. A value of 4096 (4KiB) is normally plenty.
The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal, but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number from hexadecimal to integer. Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> --- common/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)