[LEDE-DEV,packages] libwebsockets: set PROVIDES for all variants

Message ID 20170329212932.13267-1-zajec5@gmail.com
State Changes Requested
Delegated to: Rafał Miłecki
Headers show

Commit Message

Rafał Miłecki March 29, 2017, 9:29 p.m.
From: Rafał Miłecki <rafal@milecki.pl>

This allows software using libwebsockets to simply specify a
libwebsockets dependency. Otherwise a specific variant (or set of them)
would need to be specified.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 libs/libwebsockets/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Rafał Miłecki May 24, 2017, 11:33 a.m. | #1
On 30 March 2017 at 12:45, Karl Palsson <karlp@tweak.net.au> wrote:
> From conversations when we were adding this in mosquitto, we
> actually need to rename the default package to use PROVIDES
> properly.
>
> jow pointed out that you can't have PROVIDES == actual package
> name.
>
> Also, libwebsockets is maintained in the packages feed, not here
> on lede-dev.

Karl, please don't drop mailing list when replying.

It's true PKG_NAME is set to libwebsockets, but actual packages are called:
libwebsockets-openssl
libwebsockets-cyassl
libwebsockets-full

Is this a problem to have the same name in PKG_NAME and PROVIDES? I
saw this in openvpn and px5g packages and I think it is working fine.
I believe my testing of this libwebsockets patch also didn't show any
problem.

Jo can you comment on this, please?
Jo-Philipp Wich May 27, 2017, 1:25 p.m. | #2
Hi,

> Is this a problem to have the same name in PKG_NAME and PROVIDES?

Yes, this currently leads to undefined (broken) behaviour.

~ Jo

Patch

diff --git a/libs/libwebsockets/Makefile b/libs/libwebsockets/Makefile
index cfc441b5..d8d307a3 100644
--- a/libs/libwebsockets/Makefile
+++ b/libs/libwebsockets/Makefile
@@ -46,6 +46,7 @@  define Package/libwebsockets/Default
 	DEPENDS:=+zlib
 	URL:=https://libwebsockets.org
 	MAINTAINER:=Karl Palsson <karlp@etactica.com>
+	PROVIDES:=libwebsockets
 endef
 
 define Package/libwebsockets-openssl