diff mbox

[U-Boot,10/17] board_f: Use timer_init() on all archs

Message ID 20170328162733.20905-10-sjg@chromium.org
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass March 28, 2017, 4:27 p.m. UTC
More than half of the architectures use this function so let's make them
all use it.

For those which don't actually define it, we can rely on the weak function
in lib/time.c

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 common/board_f.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

York Sun March 28, 2017, 8:08 p.m. UTC | #1
On 03/28/2017 09:27 AM, Simon Glass wrote:
> More than half of the architectures use this function so let's make them
> all use it.
>
> For those which don't actually define it, we can rely on the weak function
> in lib/time.c
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  common/board_f.c | 4 ----
>  1 file changed, 4 deletions(-)
>

Reviewed-by: York Sun <york.sun@nxp.com>
Stefan Roese March 29, 2017, 5:18 a.m. UTC | #2
On 28.03.2017 18:27, Simon Glass wrote:
> More than half of the architectures use this function so let's make them
> all use it.
>
> For those which don't actually define it, we can rely on the weak function
> in lib/time.c
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Tom Rini April 6, 2017, 4:24 p.m. UTC | #3
On Tue, Mar 28, 2017 at 10:27:25AM -0600, Simon Glass wrote:

> More than half of the architectures use this function so let's make them
> all use it.
> 
> For those which don't actually define it, we can rely on the weak function
> in lib/time.c
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: York Sun <york.sun@nxp.com>
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/board_f.c b/common/board_f.c
index dcbe72d91b..9ba3163e0f 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -847,11 +847,7 @@  static const init_fnc_t init_sequence_f[] = {
 	/* get CPU and bus clocks according to the environment variable */
 	get_clocks,		/* get CPU and bus clocks (etc.) */
 #endif
-#if defined(CONFIG_ARM) || defined(CONFIG_MIPS) || defined(CONFIG_PPC) || \
-		defined(CONFIG_BLACKFIN) || defined(CONFIG_NDS32) || \
-		defined(CONFIG_SH) || defined(CONFIG_SPARC)
 	timer_init,		/* initialize timer */
-#endif
 #if defined(CONFIG_BOARD_POSTCLK_INIT)
 	board_postclk_init,
 #endif