diff mbox

[U-Boot] rockchip: arm64: rk3399: remove unconditional debug message

Message ID 1490379052-36275-1-git-send-email-philipp.tomsich@theobroma-systems.com
State Accepted
Commit f93a51186a894c19e998dcffd7713449de6dbad3
Delegated to: Simon Glass
Headers show

Commit Message

Philipp Tomsich March 24, 2017, 6:10 p.m. UTC
An earlier upstream change contained an unconditional debug message
which would show up as a message similar to the following in the
U-Boot startup (after the ATF and before the U-Boot banner):
      time 159f019, 0

This commit removes this message (instead of making if conditional on
being a debug-build), as it doesn't pertain to any initialisation done
in this file.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

---

 arch/arm/mach-rockchip/rk3399/rk3399.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Glass March 26, 2017, 3:48 a.m. UTC | #1
On 24 March 2017 at 12:10, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> An earlier upstream change contained an unconditional debug message
> which would show up as a message similar to the following in the
> U-Boot startup (after the ATF and before the U-Boot banner):
>       time 159f019, 0
>
> This commit removes this message (instead of making if conditional on
> being a debug-build), as it doesn't pertain to any initialisation done
> in this file.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> ---
>
>  arch/arm/mach-rockchip/rk3399/rk3399.c | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass April 2, 2017, 12:05 a.m. UTC | #2
On 25 March 2017 at 21:48, Simon Glass <sjg@chromium.org> wrote:
> On 24 March 2017 at 12:10, Philipp Tomsich
> <philipp.tomsich@theobroma-systems.com> wrote:
>> An earlier upstream change contained an unconditional debug message
>> which would show up as a message similar to the following in the
>> U-Boot startup (after the ATF and before the U-Boot banner):
>>       time 159f019, 0
>>
>> This commit removes this message (instead of making if conditional on
>> being a debug-build), as it doesn't pertain to any initialisation done
>> in this file.
>>
>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>
>> ---
>>
>>  arch/arm/mach-rockchip/rk3399/rk3399.c | 1 -
>>  1 file changed, 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c
index cbfd3fa..8bb950e 100644
--- a/arch/arm/mach-rockchip/rk3399/rk3399.c
+++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
@@ -40,6 +40,5 @@  int arch_cpu_init(void)
 	/* Emmc clock generator: disable the clock multipilier */
 	rk_clrreg(GRF_EMMCCORE_CON11, 0x0ff);
 
-	printf("time %x, %x\n", readl(0xff8680a8), readl(0xff8680ac));
 	return 0;
 }