diff mbox

[U-Boot,v3,2/2] rockchip: rk3288: use spl_early_init() instead of spl_init()

Message ID 20170315000634.31211-2-sjg@chromium.org
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass March 15, 2017, 12:06 a.m. UTC 
From: Eddie Cai <eddie.cai.linux@gmail.com>

Use spl_early_init() to make sure that early malloc() is initialised. This
fixes booting on firefly-rk3288, for example.

Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v3:
- Rewrite both commit messages

Changes in v2:
- Add v2 to the series since this is a new version

 arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Pont March 15, 2017, 8:21 a.m. UTC | #1 
Simon wrote...

> diff --git a/arch/arm/mach-rockchip/rk3288-board-spl.c b/arch/arm/mach-
> rockchip/rk3288-board-spl.c
> index e51e19bb2d..f494843663 100644
> --- a/arch/arm/mach-rockchip/rk3288-board-spl.c
> +++ b/arch/arm/mach-rockchip/rk3288-board-spl.c
> @@ -185,7 +185,7 @@ void board_init_f(ulong dummy)
>  	debug_uart_init();
>  #endif
> 
> -	ret = spl_init();
> +	ret = spl_early_init();
>  	if (ret) {
>  		debug("spl_init() failed: %d\n", ret);

Shouldn't the function name used in the debug statement be changed to spl_early_init()?

-Andy.
diff mbox

Patch

diff --git a/arch/arm/mach-rockchip/rk3288-board-spl.c b/arch/arm/mach-rockchip/rk3288-board-spl.c
index e51e19bb2d..f494843663 100644
--- a/arch/arm/mach-rockchip/rk3288-board-spl.c
+++ b/arch/arm/mach-rockchip/rk3288-board-spl.c
@@ -185,7 +185,7 @@  void board_init_f(ulong dummy)
 	debug_uart_init();
 #endif
 
-	ret = spl_init();
+	ret = spl_early_init();
 	if (ret) {
 		debug("spl_init() failed: %d\n", ret);
 		hang();