diff mbox

[LEDE-DEV] kernel: Add iTCO_wdt watchdog timer module support

Message ID 20170311224816.31578-1-michael@michaelmarley.com
State Changes Requested
Headers show

Commit Message

Michael Marley March 11, 2017, 10:48 p.m. UTC
From: Michael Marley <michael@michaelmarley.com>

This supports the Intel TCO Watchdog Timer Device, which has been
nearly ubiquitous in Intel chipsets for almost 20 years.

Signed-off-by: Michael Marley <michael@michaelmarley.com>
---
 package/kernel/linux/modules/other.mk | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Felix Fietkau March 12, 2017, 10:56 a.m. UTC | #1
On 2017-03-11 23:48, michael@michaelmarley.com wrote:
> From: Michael Marley <michael@michaelmarley.com>
> 
> This supports the Intel TCO Watchdog Timer Device, which has been
> nearly ubiquitous in Intel chipsets for almost 20 years.
> 
> Signed-off-by: Michael Marley <michael@michaelmarley.com>
I think this should be enabled in the kernel config for the relevant x86
subtargets.

- Felix
Philip Prindeville March 14, 2017, 12:37 a.m. UTC | #2
Did you look at:

https://github.com/openwrt/openwrt/pull/326

it might be easier just to cherry-pick this in.


> On Mar 11, 2017, at 3:48 PM, michael@michaelmarley.com wrote:
> 
> From: Michael Marley <michael@michaelmarley.com>
> 
> This supports the Intel TCO Watchdog Timer Device, which has been
> nearly ubiquitous in Intel chipsets for almost 20 years.
> 
> Signed-off-by: Michael Marley <michael@michaelmarley.com>
> ---
> package/kernel/linux/modules/other.mk | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> 
> diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/other.mk
> index 40869c6bb0..6b7afb75d9 100644
> --- a/package/kernel/linux/modules/other.mk
> +++ b/package/kernel/linux/modules/other.mk
> @@ -1003,3 +1003,18 @@ define KernelPackage/tpm-i2c-atmel/description
> endef
> 
> $(eval $(call KernelPackage,tpm-i2c-atmel))
> +
> +define KernelPackage/iTCO_wdt
> +  SUBMENU:=$(OTHER_MENU)
> +  TITLE:=Intel TCO watchdog timer driver
> +  KCONFIG:=CONFIG_ITCO_WDT
> +  FILES:=$(LINUX_DIR)/drivers/$(WATCHDOG_DIR)/iTCO_wdt.ko
> +  AUTOLOAD:=$(call AutoLoad,40,iTCO_wdt,1)
> +endef
> +
> +define KernelPackage/iTCO_wdt/description
> +	This enables the driver for the watchdog timer hardware included in
> +	many Intel chipsets.
> +endef
> +
> +$(eval $(call KernelPackage,iTCO_wdt))
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev
Michael Marley March 14, 2017, 1:09 a.m. UTC | #3
CONFIG_ITCO_WDT is actually already set to "y" in LEDE's current kernel 
configuration, but it seems that some dependency is getting compiled as 
a module, also forcing iTCO_wdt to be compiled as a module.  Felix said 
to just build it into the kernel anyway, which I plan to do, but I 
haven't had a chance to look at what is causing it to build as a module 
instead of into the kernel yet.

Michael


On 03/13/17 20:37, Philip Prindeville wrote:
> Did you look at:
>
> https://github.com/openwrt/openwrt/pull/326
>
> it might be easier just to cherry-pick this in.
>
>
>> On Mar 11, 2017, at 3:48 PM, michael@michaelmarley.com wrote:
>>
>> From: Michael Marley <michael@michaelmarley.com>
>>
>> This supports the Intel TCO Watchdog Timer Device, which has been
>> nearly ubiquitous in Intel chipsets for almost 20 years.
>>
>> Signed-off-by: Michael Marley <michael@michaelmarley.com>
>> ---
>> package/kernel/linux/modules/other.mk | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/other.mk
>> index 40869c6bb0..6b7afb75d9 100644
>> --- a/package/kernel/linux/modules/other.mk
>> +++ b/package/kernel/linux/modules/other.mk
>> @@ -1003,3 +1003,18 @@ define KernelPackage/tpm-i2c-atmel/description
>> endef
>>
>> $(eval $(call KernelPackage,tpm-i2c-atmel))
>> +
>> +define KernelPackage/iTCO_wdt
>> +  SUBMENU:=$(OTHER_MENU)
>> +  TITLE:=Intel TCO watchdog timer driver
>> +  KCONFIG:=CONFIG_ITCO_WDT
>> +  FILES:=$(LINUX_DIR)/drivers/$(WATCHDOG_DIR)/iTCO_wdt.ko
>> +  AUTOLOAD:=$(call AutoLoad,40,iTCO_wdt,1)
>> +endef
>> +
>> +define KernelPackage/iTCO_wdt/description
>> +	This enables the driver for the watchdog timer hardware included in
>> +	many Intel chipsets.
>> +endef
>> +
>> +$(eval $(call KernelPackage,iTCO_wdt))
>> -- 
>> 2.11.0
>>
>>
>> _______________________________________________
>> Lede-dev mailing list
>> Lede-dev@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/lede-dev
diff mbox

Patch

diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/other.mk
index 40869c6bb0..6b7afb75d9 100644
--- a/package/kernel/linux/modules/other.mk
+++ b/package/kernel/linux/modules/other.mk
@@ -1003,3 +1003,18 @@  define KernelPackage/tpm-i2c-atmel/description
 endef
 
 $(eval $(call KernelPackage,tpm-i2c-atmel))
+
+define KernelPackage/iTCO_wdt
+  SUBMENU:=$(OTHER_MENU)
+  TITLE:=Intel TCO watchdog timer driver
+  KCONFIG:=CONFIG_ITCO_WDT
+  FILES:=$(LINUX_DIR)/drivers/$(WATCHDOG_DIR)/iTCO_wdt.ko
+  AUTOLOAD:=$(call AutoLoad,40,iTCO_wdt,1)
+endef
+
+define KernelPackage/iTCO_wdt/description
+	This enables the driver for the watchdog timer hardware included in
+	many Intel chipsets.
+endef
+
+$(eval $(call KernelPackage,iTCO_wdt))