| Message ID | 20170216235900.15629-1-ruscur@russell.cc (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Can you make the comment/title a bit more descriptive... Have a look at c674e703cb1028e468527163074810b4a17bf379 where we added the p8. > Signed-off-by: Russell Currey <ruscur@russell.cc> Other than that, the code looks good.. Acked-By: Michael Neuling <mikey@neuling.org> > --- > arch/powerpc/kernel/cputable.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c > index 6a82ef039c50..d23a54b09436 100644 > --- a/arch/powerpc/kernel/cputable.c > +++ b/arch/powerpc/kernel/cputable.c > @@ -386,6 +386,25 @@ static struct cpu_spec __initdata cpu_specs[] = { > .machine_check_early = > __machine_check_early_realmode_p8, > .platform = "power8", > }, > + { /* 3.00-compliant processor, i.e. Power9 "architected" mode > */ > + .pvr_mask = 0xffffffff, > + .pvr_value = 0x0f000005, > + .cpu_name = "POWER9 (architected)", > + .cpu_features = CPU_FTRS_POWER9, > + .cpu_user_features = COMMON_USER_POWER9, > + .cpu_user_features2 = COMMON_USER2_POWER9, > + .mmu_features = MMU_FTRS_POWER9, > + .icache_bsize = 128, > + .dcache_bsize = 128, > + .num_pmcs = 6, > + .pmc_type = PPC_PMC_IBM, > + .oprofile_cpu_type = "ppc64/ibm-compat-v1", > + .oprofile_type = PPC_OPROFILE_INVALID, > + .cpu_setup = __setup_cpu_power9, > + .cpu_restore = __restore_cpu_power9, > + .flush_tlb = __flush_tlb_power9, > + .platform = "power9", > + }, > { /* Power7 */ > .pvr_mask = 0xffff0000, > .pvr_value = 0x003f0000,
On Fri, 2017-02-17 at 11:57 +1100, Michael Neuling wrote: > Can you make the comment/title a bit more descriptive... Have a look at > c674e703cb1028e468527163074810b4a17bf379 where we added the p8. > I had a look at that when I was making the commit but I didn't think it really added anything valuable (though I suppose mentioning cputable in the commit message might add clarity). I guess A PVR of 0x0F000005 means we are arch v3.00 compliant (i.e. POWER9) to steal from yours... > > > Signed-off-by: Russell Currey <ruscur@russell.cc> > > Other than that, the code looks good.. > > Acked-By: Michael Neuling <mikey@neuling.org> > > > > > --- > > arch/powerpc/kernel/cputable.c | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c > > index 6a82ef039c50..d23a54b09436 100644 > > --- a/arch/powerpc/kernel/cputable.c > > +++ b/arch/powerpc/kernel/cputable.c > > @@ -386,6 +386,25 @@ static struct cpu_spec __initdata cpu_specs[] = { > > .machine_check_early = > > __machine_check_early_realmode_p8, > > .platform = "power8", > > }, > > + { /* 3.00-compliant processor, i.e. Power9 "architected" > > mode > > */ > > + .pvr_mask = 0xffffffff, > > + .pvr_value = 0x0f000005, > > + .cpu_name = "POWER9 (architected)", > > + .cpu_features = CPU_FTRS_POWER9, > > + .cpu_user_features = COMMON_USER_POWER9, > > + .cpu_user_features2 = COMMON_USER2_POWER9, > > + .mmu_features = MMU_FTRS_POWER9, > > + .icache_bsize = 128, > > + .dcache_bsize = 128, > > + .num_pmcs = 6, > > + .pmc_type = PPC_PMC_IBM, > > + .oprofile_cpu_type = "ppc64/ibm-compat-v1", > > + .oprofile_type = PPC_OPROFILE_INVALID, > > + .cpu_setup = __setup_cpu_power9, > > + .cpu_restore = __restore_cpu_power9, > > + .flush_tlb = __flush_tlb_power9, > > + .platform = "power9", > > + }, > > { /* Power7 */ > > .pvr_mask = 0xffff0000, > > .pvr_value = 0x003f0000,
On Fri, 2017-02-17 at 10:59 +1100, Russell Currey wrote: > Signed-off-by: Russell Currey <ruscur@russell.cc> Tested-in-QEMU-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com> > --- > arch/powerpc/kernel/cputable.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/powerpc/kernel/cputable.c > b/arch/powerpc/kernel/cputable.c > index 6a82ef039c50..d23a54b09436 100644 > --- a/arch/powerpc/kernel/cputable.c > +++ b/arch/powerpc/kernel/cputable.c > @@ -386,6 +386,25 @@ static struct cpu_spec __initdata cpu_specs[] = > { > .machine_check_early = > __machine_check_early_realmode_p8, > .platform = "power8", > }, > + { /* 3.00-compliant processor, i.e. Power9 > "architected" mode */ > + .pvr_mask = 0xffffffff, > + .pvr_value = 0x0f000005, > + .cpu_name = "POWER9 (architected)", > + .cpu_features = CPU_FTRS_POWER9, > + .cpu_user_features = COMMON_USER_POWER9, > + .cpu_user_features2 = COMMON_USER2_POWER9, > + .mmu_features = MMU_FTRS_POWER9, > + .icache_bsize = 128, > + .dcache_bsize = 128, > + .num_pmcs = 6, > + .pmc_type = PPC_PMC_IBM, > + .oprofile_cpu_type = "ppc64/ibm-compat-v1", > + .oprofile_type = > PPC_OPROFILE_INVALID, > + .cpu_setup = __setup_cpu_power9, > + .cpu_restore = __restore_cpu_power9, > + .flush_tlb = __flush_tlb_power9, > + .platform = "power9", > + }, > { /* Power7 */ > .pvr_mask = 0xffff0000, > .pvr_value = 0x003f0000,
diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c index 6a82ef039c50..d23a54b09436 100644 --- a/arch/powerpc/kernel/cputable.c +++ b/arch/powerpc/kernel/cputable.c @@ -386,6 +386,25 @@ static struct cpu_spec __initdata cpu_specs[] = { .machine_check_early = __machine_check_early_realmode_p8, .platform = "power8", }, + { /* 3.00-compliant processor, i.e. Power9 "architected" mode */ + .pvr_mask = 0xffffffff, + .pvr_value = 0x0f000005, + .cpu_name = "POWER9 (architected)", + .cpu_features = CPU_FTRS_POWER9, + .cpu_user_features = COMMON_USER_POWER9, + .cpu_user_features2 = COMMON_USER2_POWER9, + .mmu_features = MMU_FTRS_POWER9, + .icache_bsize = 128, + .dcache_bsize = 128, + .num_pmcs = 6, + .pmc_type = PPC_PMC_IBM, + .oprofile_cpu_type = "ppc64/ibm-compat-v1", + .oprofile_type = PPC_OPROFILE_INVALID, + .cpu_setup = __setup_cpu_power9, + .cpu_restore = __restore_cpu_power9, + .flush_tlb = __flush_tlb_power9, + .platform = "power9", + }, { /* Power7 */ .pvr_mask = 0xffff0000, .pvr_value = 0x003f0000,
Signed-off-by: Russell Currey <ruscur@russell.cc> --- arch/powerpc/kernel/cputable.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)