Patchwork [U-Boot] ppc4xx: Remove bogus comment from start.S

login
register
mail settings
Submitter Stefan Roese
Date Nov. 23, 2010, 1:33 p.m.
Message ID <1290519180-6764-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/72657/
State Superseded
Delegated to: Stefan Roese
Headers show

Comments

Stefan Roese - Nov. 23, 2010, 1:33 p.m.
Signed-off-by: Stefan Roese <sr@denx.de>
---
 arch/powerpc/cpu/ppc4xx/start.S |   17 +++--------------
 1 files changed, 3 insertions(+), 14 deletions(-)
Wolfgang Denk - Nov. 23, 2010, 7:58 p.m.
Dear Stefan Roese,

In message <1290519180-6764-1-git-send-email-sr@denx.de> you wrote:
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  arch/powerpc/cpu/ppc4xx/start.S |   17 +++--------------
>  1 files changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/powerpc/cpu/ppc4xx/start.S b/arch/powerpc/cpu/ppc4xx/start.S
> index 65195f5..c36c13b 100644
> --- a/arch/powerpc/cpu/ppc4xx/start.S
> +++ b/arch/powerpc/cpu/ppc4xx/start.S
> @@ -48,21 +48,10 @@
>   *-------------------------------------------------------------------------------
>   */
>  
> -/*  U-Boot - Startup Code for AMCC 4xx PowerPC based Embedded Boards
> - *
> - *
> - *  The processor starts at 0xfffffffc and the code is executed
> - *  from flash/rom.
> - *  in memory, but as long we don't jump around before relocating.
> - *  board_init lies at a quite high address and when the cpu has
> - *  jumped there, everything is ok.
> - *  This works because the cpu gives the FLASH (CS0) the whole
> - *  address space at startup, and board_init lies as a echo of
> - *  the flash somewhere up there in the memorymap.
> - *
> - *  board_init will change CS0 to be positioned at the correct
> - *  address and (s)dram will be positioned at address 0
> +/*
> + * Startup code for IBM/AMCC PowerPC 4xx (PPC4xx) based boards
>   */

It appears that the old comment contained some information about how
booting and especially address resolution works on 4xx.  Is there some
way to keep this (non-obvious, at least to me) information, instead of
just deleting it?

Best regards,

Wolfgang Denk
Stefan Roese - Nov. 26, 2010, 2:20 p.m.
Hi Wolfgang,

On Tuesday 23 November 2010 20:58:24 Wolfgang Denk wrote:
> It appears that the old comment contained some information about how
> booting and especially address resolution works on 4xx.  Is there some
> way to keep this (non-obvious, at least to me) information, instead of
> just deleting it?

The old comment was really screwed up. I'll send a patch with a (hopefully) 
better description shortly.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

Patch

diff --git a/arch/powerpc/cpu/ppc4xx/start.S b/arch/powerpc/cpu/ppc4xx/start.S
index 65195f5..c36c13b 100644
--- a/arch/powerpc/cpu/ppc4xx/start.S
+++ b/arch/powerpc/cpu/ppc4xx/start.S
@@ -48,21 +48,10 @@ 
  *-------------------------------------------------------------------------------
  */
 
-/*  U-Boot - Startup Code for AMCC 4xx PowerPC based Embedded Boards
- *
- *
- *  The processor starts at 0xfffffffc and the code is executed
- *  from flash/rom.
- *  in memory, but as long we don't jump around before relocating.
- *  board_init lies at a quite high address and when the cpu has
- *  jumped there, everything is ok.
- *  This works because the cpu gives the FLASH (CS0) the whole
- *  address space at startup, and board_init lies as a echo of
- *  the flash somewhere up there in the memorymap.
- *
- *  board_init will change CS0 to be positioned at the correct
- *  address and (s)dram will be positioned at address 0
+/*
+ * Startup code for IBM/AMCC PowerPC 4xx (PPC4xx) based boards
  */
+
 #include <asm-offsets.h>
 #include <config.h>
 #include <asm/ppc4xx.h>