| Message ID | 20170209040012.20324-6-lokeshvutla@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Feb 09, 2017 at 09:30:12AM +0530, Lokesh Vutla wrote: > Enable SPL_DM on all DRA7 based platforms. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> [snip] > +++ b/include/configs/ti_omap5_common.h > @@ -45,7 +45,7 @@ > * Hardware drivers > */ > #define CONFIG_SYS_NS16550_CLK 48000000 > -#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_DM_SERIAL) > +#if !defined(CONFIG_DM_SERIAL) > #define CONFIG_SYS_NS16550_SERIAL > #define CONFIG_SYS_NS16550_REG_SIZE (-4) > #endif > @@ -163,14 +163,8 @@ > #define CONFIG_SPL_NAND_AM33XX_BCH /* ELM support */ > #endif > > -/* > - * Disable MMC DM for SPL build and can be re-enabled after adding > - * DM support in SPL > - */ > #ifdef CONFIG_SPL_BUILD > -#undef CONFIG_DM_MMC > #undef CONFIG_TIMER > -#undef CONFIG_DM_ETH > #endif > > #endif /* __CONFIG_TI_OMAP5_COMMON_H */ Do you know why we need to disable timer?
On Friday 10 February 2017 09:01 AM, Tom Rini wrote: > On Thu, Feb 09, 2017 at 09:30:12AM +0530, Lokesh Vutla wrote: > >> Enable SPL_DM on all DRA7 based platforms. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > [snip] >> +++ b/include/configs/ti_omap5_common.h >> @@ -45,7 +45,7 @@ >> * Hardware drivers >> */ >> #define CONFIG_SYS_NS16550_CLK 48000000 >> -#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_DM_SERIAL) >> +#if !defined(CONFIG_DM_SERIAL) >> #define CONFIG_SYS_NS16550_SERIAL >> #define CONFIG_SYS_NS16550_REG_SIZE (-4) >> #endif >> @@ -163,14 +163,8 @@ >> #define CONFIG_SPL_NAND_AM33XX_BCH /* ELM support */ >> #endif >> >> -/* >> - * Disable MMC DM for SPL build and can be re-enabled after adding >> - * DM support in SPL >> - */ >> #ifdef CONFIG_SPL_BUILD >> -#undef CONFIG_DM_MMC >> #undef CONFIG_TIMER >> -#undef CONFIG_DM_ETH >> #endif >> >> #endif /* __CONFIG_TI_OMAP5_COMMON_H */ > > Do you know why we need to disable timer? drivers/timer/ is not yet include in SPL and also we need to implement timer_early in SPL. I guess that is a different task. So till then I though of disabling it here. Thanks and regards, Lokesh
On Fri, Feb 10, 2017 at 07:06:31PM +0530, Lokesh Vutla wrote: > On Friday 10 February 2017 09:01 AM, Tom Rini wrote: > > On Thu, Feb 09, 2017 at 09:30:12AM +0530, Lokesh Vutla wrote: > > > >> Enable SPL_DM on all DRA7 based platforms. > >> > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > [snip] > >> +++ b/include/configs/ti_omap5_common.h > >> @@ -45,7 +45,7 @@ > >> * Hardware drivers > >> */ > >> #define CONFIG_SYS_NS16550_CLK 48000000 > >> -#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_DM_SERIAL) > >> +#if !defined(CONFIG_DM_SERIAL) > >> #define CONFIG_SYS_NS16550_SERIAL > >> #define CONFIG_SYS_NS16550_REG_SIZE (-4) > >> #endif > >> @@ -163,14 +163,8 @@ > >> #define CONFIG_SPL_NAND_AM33XX_BCH /* ELM support */ > >> #endif > >> > >> -/* > >> - * Disable MMC DM for SPL build and can be re-enabled after adding > >> - * DM support in SPL > >> - */ > >> #ifdef CONFIG_SPL_BUILD > >> -#undef CONFIG_DM_MMC > >> #undef CONFIG_TIMER > >> -#undef CONFIG_DM_ETH > >> #endif > >> > >> #endif /* __CONFIG_TI_OMAP5_COMMON_H */ > > > > Do you know why we need to disable timer? > > drivers/timer/ is not yet include in SPL and also we need to implement > timer_early in SPL. I guess that is a different task. So till then I > though of disabling it here. OK thanks. Reviewed-by: Tom Rini <trini@konsulko.com>
diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig index 26b26cc4cd..8a2b68c417 100644 --- a/configs/dra7xx_evm_defconfig +++ b/configs/dra7xx_evm_defconfig @@ -14,7 +14,9 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_STACK_R=y +CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DMA_SUPPORT=y CONFIG_SPL_OS_BOOT=y CONFIG_HUSH_PARSER=y @@ -52,8 +54,10 @@ CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_ISO_PARTITION=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc dra71-evm" CONFIG_DM=y +CONFIG_SPL_DM=y # CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y @@ -96,4 +100,3 @@ CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 -CONFIG_SPL_OF_LIBFDT=y diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig index 244940cd6c..12f2c3a786 100644 --- a/configs/dra7xx_hs_evm_defconfig +++ b/configs/dra7xx_hs_evm_defconfig @@ -20,7 +20,9 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_STACK_R=y +CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DMA_SUPPORT=y CONFIG_HUSH_PARSER=y CONFIG_FASTBOOT=y @@ -57,8 +59,10 @@ CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_ISO_PARTITION=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc dra71-evm" CONFIG_DM=y +CONFIG_SPL_DM=y # CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y @@ -101,4 +105,3 @@ CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 -CONFIG_SPL_OF_LIBFDT=y diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h index bf8c041fb7..827d076e76 100644 --- a/include/configs/dra7xx_evm.h +++ b/include/configs/dra7xx_evm.h @@ -123,11 +123,6 @@ #define CONFIG_SF_DEFAULT_MODE SPI_MODE_0 #define CONFIG_QSPI_QUAD_SUPPORT -#ifdef CONFIG_SPL_BUILD -#undef CONFIG_DM_SPI -#undef CONFIG_DM_SPI_FLASH -#endif - /* * Default to using SPI for environment, etc. * 0x000000 - 0x040000 : QSPI.SPL (256KiB) diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h index 37d65653a5..8f65c2242f 100644 --- a/include/configs/ti_omap5_common.h +++ b/include/configs/ti_omap5_common.h @@ -45,7 +45,7 @@ * Hardware drivers */ #define CONFIG_SYS_NS16550_CLK 48000000 -#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_DM_SERIAL) +#if !defined(CONFIG_DM_SERIAL) #define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE (-4) #endif @@ -163,14 +163,8 @@ #define CONFIG_SPL_NAND_AM33XX_BCH /* ELM support */ #endif -/* - * Disable MMC DM for SPL build and can be re-enabled after adding - * DM support in SPL - */ #ifdef CONFIG_SPL_BUILD -#undef CONFIG_DM_MMC #undef CONFIG_TIMER -#undef CONFIG_DM_ETH #endif #endif /* __CONFIG_TI_OMAP5_COMMON_H */
Enable SPL_DM on all DRA7 based platforms. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- configs/dra7xx_evm_defconfig | 5 ++++- configs/dra7xx_hs_evm_defconfig | 5 ++++- include/configs/dra7xx_evm.h | 5 ----- include/configs/ti_omap5_common.h | 8 +------- 4 files changed, 9 insertions(+), 14 deletions(-)