| Message ID | 1485912970-7567-6-git-send-email-andre.przywara@arm.com |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On Wed, Feb 01, 2017 at 01:36:02AM +0000, Andre Przywara wrote: > For some reason we were pretty conservative when defining the maximum > SPL size for the Allwinner A80(sun9i) SoC. > According to the manual the SRAM A1 is even 40KB, but the BROM > probably still has the 32 KiB load limit. For the sake of simplicity, > merge the SPL memory definitions for the A64 and A80 SoCs, since both > SoC share the BROM/SRAM A1 memory layout. > This helps to further simplify this is in the next patch. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Maxime
On Thu, Feb 2, 2017 at 1:25 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Wed, Feb 01, 2017 at 01:36:02AM +0000, Andre Przywara wrote: >> For some reason we were pretty conservative when defining the maximum >> SPL size for the Allwinner A80(sun9i) SoC. >> According to the manual the SRAM A1 is even 40KB, but the BROM >> probably still has the 32 KiB load limit. For the sake of simplicity, >> merge the SPL memory definitions for the A64 and A80 SoCs, since both >> SoC share the BROM/SRAM A1 memory layout. >> This helps to further simplify this is in the next patch. >> >> Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Jagan Teki <jagan@openedev.com> thanks!
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 0f40c7f..2b67827 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -186,12 +186,9 @@ #define CONFIG_SPL_BOARD_LOAD_IMAGE #endif -#if defined(CONFIG_MACH_SUN9I) -#define CONFIG_SPL_TEXT_BASE 0x10040 /* sram start+header */ -#define CONFIG_SPL_MAX_SIZE 0x5fc0 /* ? KiB on sun9i */ -#elif defined(CONFIG_MACH_SUN50I) +#if defined(CONFIG_MACH_SUN9I) || defined(CONFIG_MACH_SUN50I) #define CONFIG_SPL_TEXT_BASE 0x10040 /* sram start+header */ -#define CONFIG_SPL_MAX_SIZE 0x7fc0 /* 32 KiB on sun50i */ +#define CONFIG_SPL_MAX_SIZE 0x7fc0 /* 32 KiB on sun9/50i */ #else #define CONFIG_SPL_TEXT_BASE 0x40 /* sram start+header */ #define CONFIG_SPL_MAX_SIZE 0x5fc0 /* 24KB on sun4i/sun7i */
For some reason we were pretty conservative when defining the maximum SPL size for the Allwinner A80(sun9i) SoC. According to the manual the SRAM A1 is even 40KB, but the BROM probably still has the 32 KiB load limit. For the sake of simplicity, merge the SPL memory definitions for the A64 and A80 SoCs, since both SoC share the BROM/SRAM A1 memory layout. This helps to further simplify this is in the next patch. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- include/configs/sunxi-common.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)