| Message ID | 20170131162122.29408-1-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PULL 00/41] Chr split patches
Message-id: 20170131162122.29408-1-marcandre.lureau@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20170131162122.29408-1-marcandre.lureau@redhat.com -> patchew/20170131162122.29408-1-marcandre.lureau@redhat.com
- [tag update] patchew/cover.1485878688.git.berto@igalia.com -> patchew/cover.1485878688.git.berto@igalia.com
Switched to a new branch 'test'
95ffd75 char: headers clean-up
21c900a char: move parallel chardev in its own file
55df019 char: move serial chardev to its own file
e7e9361 char: move pty chardev in its own file
f715f19 char: move pipe chardev in its own file
262f7e3 char: move console in its own file
9a9d6eb char: move stdio in its own file
5ffc3c6 char: move file chardev in its own file
050e718 char: move udp chardev in its own file
74b2905 char: move socket chardev to its own file
e65f01f char: move win-stdio into its own file
d77168a char: move win chardev base class in its own file
eac8509 char: move fd chardev in its own file
701cd50 char: move QIOChannel-related stuff to char-io.h
d2193c2 char: remove unused READ_RETRIES
e63481d char: rename and move to header CHR_READ_BUF_LEN
359c68c char: move ringbuf/memory to its own file
318282b char: move mux to its own file
20c8425 char: move null chardev to its own file
793d26c char: make null_chr_write() the default method
479d2f7 char: create chardev-obj-y
e52f6c3 char: move to chardev/
53335b9 char: remove class kind field
fba7593 char: rename remaining CharDriver to Chardev
768322b char: get rid of CharDriver
23766b7 char: remove chr_free
df541a5 char-fd: convert to finalize
6fddb56 char-win: convert to finalize
f90dce0 char-win: do not override chr_free
010dcf3 char-win-stdio: convert to finalize
da6b699 char-stdio: convert to finalize
676ec0e char-parallel: convert parallel to finalize
122b1e6 char-ringbuf: convert to finalize
ae17198 char-pty: convert to finalize
a9dd8b2 char-socket: convert to finalize
7ac8d6b char-udp: convert to finalize
c0062a9 mux: convert to finalize
42d5c45 msmouse: convert to finalize
a03aea1 baum: convert to finalize
0026a57 spice-qemu-char: convert to finalize
cbe8a1d MAINTAINERS: add myself to qemu-char.c
=== OUTPUT BEGIN ===
Checking PATCH 1/41: MAINTAINERS: add myself to qemu-char.c...
Checking PATCH 2/41: spice-qemu-char: convert to finalize...
Checking PATCH 3/41: baum: convert to finalize...
Checking PATCH 4/41: msmouse: convert to finalize...
Checking PATCH 5/41: mux: convert to finalize...
Checking PATCH 6/41: char-udp: convert to finalize...
Checking PATCH 7/41: char-socket: convert to finalize...
Checking PATCH 8/41: char-pty: convert to finalize...
Checking PATCH 9/41: char-ringbuf: convert to finalize...
Checking PATCH 10/41: char-parallel: convert parallel to finalize...
WARNING: architecture specific defines should be avoided
#49: FILE: qemu-char.c:4699:
+#if defined(__linux__)
WARNING: line over 80 characters
#58: FILE: qemu-char.c:4708:
+#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)
total: 0 errors, 2 warnings, 52 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/41: char-stdio: convert to finalize...
Checking PATCH 12/41: char-win-stdio: convert to finalize...
Checking PATCH 13/41: char-win: do not override chr_free...
Checking PATCH 14/41: char-win: convert to finalize...
Checking PATCH 15/41: char-fd: convert to finalize...
Checking PATCH 16/41: char: remove chr_free...
Checking PATCH 17/41: char: get rid of CharDriver...
Checking PATCH 18/41: char: rename remaining CharDriver to Chardev...
Checking PATCH 19/41: char: remove class kind field...
Checking PATCH 20/41: char: move to chardev/...
Checking PATCH 21/41: char: create chardev-obj-y...
Checking PATCH 22/41: char: make null_chr_write() the default method...
Checking PATCH 23/41: char: move null chardev to its own file...
Checking PATCH 24/41: char: move mux to its own file...
Checking PATCH 25/41: char: move ringbuf/memory to its own file...
Checking PATCH 26/41: char: rename and move to header CHR_READ_BUF_LEN...
Checking PATCH 27/41: char: remove unused READ_RETRIES...
Checking PATCH 28/41: char: move QIOChannel-related stuff to char-io.h...
Checking PATCH 29/41: char: move fd chardev in its own file...
Checking PATCH 30/41: char: move win chardev base class in its own file...
Checking PATCH 31/41: char: move win-stdio into its own file...
Checking PATCH 32/41: char: move socket chardev to its own file...
Checking PATCH 33/41: char: move udp chardev in its own file...
Checking PATCH 34/41: char: move file chardev in its own file...
Checking PATCH 35/41: char: move stdio in its own file...
Checking PATCH 36/41: char: move console in its own file...
Checking PATCH 37/41: char: move pipe chardev in its own file...
Checking PATCH 38/41: char: move pty chardev in its own file...
WARNING: architecture specific defines should be avoided
#64: FILE: chardev/char-pty.c:34:
+#if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
total: 0 errors, 1 warnings, 577 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 39/41: char: move serial chardev to its own file...
ERROR: if this code is redundant consider removing it
#91: FILE: chardev/char-serial.c:61:
+#if 0
ERROR: braces {} are necessary for all arms of this statement
#97: FILE: chardev/char-serial.c:67:
+#define check_speed(val) if (speed <= val) { spd = B##val; break; }
[...]
total: 2 errors, 0 warnings, 692 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 40/41: char: move parallel chardev in its own file...
WARNING: architecture specific defines should be avoided
#60: FILE: chardev/char-parallel.c:30:
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
WARNING: architecture specific defines should be avoided
#68: FILE: chardev/char-parallel.c:38:
+#ifdef __linux__
WARNING: architecture specific defines should be avoided
#77: FILE: chardev/char-parallel.c:47:
+#if defined(__linux__)
WARNING: line over 80 characters
#205: FILE: chardev/char-parallel.c:175:
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)
WARNING: architecture specific defines should be avoided
#205: FILE: chardev/char-parallel.c:175:
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)
WARNING: architecture specific defines should be avoided
#306: FILE: chardev/char-parallel.c:276:
+#if defined(__linux__)
WARNING: architecture specific defines should be avoided
#316: FILE: chardev/char-parallel.c:286:
+#if defined(__linux__)
WARNING: architecture specific defines should be avoided
#379: FILE: chardev/char-parallel.h:27:
+#if defined(__linux__) || defined(__FreeBSD__) || \
total: 0 errors, 8 warnings, 687 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 41/41: char: headers clean-up...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 31 January 2017 at 16:20, Marc-André Lureau <marcandre.lureau@redhat.com> wrote: > The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-01-30 10:23:20 +0000) > > are available in the git repository at: > > https://github.com/elmarco/qemu.git tags/chr-split-pull-request > > for you to fetch changes up to 3766519be2843e0947425cafd1e7e205dd63f0fd: > > char: headers clean-up (2017-01-31 13:03:48 +0400) > > ---------------------------------------------------------------- > 'make check' fails on a linux-user-targets-only build: tests/test-char.o: In function `char_stdio_test_subprocess': /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:47: undefined reference to `qemu_chr_new' /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:50: undefined reference to `qemu_chr_fe_init' /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:51: undefined reference to `qemu_chr_fe_set_open' /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:52: undefined reference to `qemu_chr_fe_write' [etc etc etc] thanks -- PMM