Patchwork [4/4] powerpc: hash_preload: avoid avoidable void

login
register
mail settings
Submitter Michael Neuling
Date Nov. 18, 2010, 4:52 a.m.
Message ID <20101118045248.086797756@neuling.org>
Download mbox | patch
Permalink /patch/72051/
State Accepted
Commit 0b97fee0ef9b0a0445520f90980410f905c6f9da
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Michael Neuling - Nov. 18, 2010, 4:52 a.m.
Change pgdir from a void to real type.  Having this as a void is
stupid and has already caused 1 bug.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
 arch/powerpc/mm/hash_utils_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

Index: linux-2.6-ozlabs/arch/powerpc/mm/hash_utils_64.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/mm/hash_utils_64.c
+++ linux-2.6-ozlabs/arch/powerpc/mm/hash_utils_64.c
@@ -1070,7 +1070,7 @@ 
 		  unsigned long access, unsigned long trap)
 {
 	unsigned long vsid;
-	void *pgdir;
+	pgd_t *pgdir;
 	pte_t *ptep;
 	unsigned long flags;
 	int rc, ssize, local = 0;