Patchwork [U-Boot] cmd_nand: document "scrub" options

login
register
mail settings
Submitter Mike Frysinger
Date Sept. 22, 2010, 4:05 a.m.
Message ID <1285128309-20134-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/71851/
State Superseded
Headers show

Comments

Mike Frysinger - Sept. 22, 2010, 4:05 a.m.
The current documentation for the "scrub" option implies it takes no
options at all.  This can be annoying when you only want to scrub a
few blocks and not an entire device.  Good thing the code already
supports this though since it takes the same arguments as the "erase"
option.  Inform people!

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 common/cmd_nand.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Scott Wood - Sept. 22, 2010, 3:44 p.m.
On Wed, 22 Sep 2010 00:05:09 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> The current documentation for the "scrub" option implies it takes no
> options at all.  This can be annoying when you only want to scrub a
> few blocks and not an entire device.  Good thing the code already
> supports this though since it takes the same arguments as the "erase"
> option.  Inform people!
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  common/cmd_nand.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> index 3f1d077..7c77983 100644
> --- a/common/cmd_nand.c
> +++ b/common/cmd_nand.c
> @@ -593,6 +593,7 @@ U_BOOT_CMD(
>  	"nand bad - show bad blocks\n"
>  	"nand dump[.oob] off - dump page\n"
>  	"nand scrub - really clean NAND erasing bad blocks (UNSAFE)\n"
> +	"    takes the same options as erase\n"
>  	"nand markbad off [...] - mark bad block(s) at offset (UNSAFE)\n"
>  	"nand biterr off - make a bit error at offset (UNSAFE)"
>  #ifdef CONFIG_CMD_NAND_LOCK_UNLOCK

I've already got this in my next branch:

	"nand scrub off size | scrub.part partition | scrub.chip\n"
	"    really clean NAND erasing bad blocks (UNSAFE)\n"

-Scott

Patch

diff --git a/common/cmd_nand.c b/common/cmd_nand.c
index 3f1d077..7c77983 100644
--- a/common/cmd_nand.c
+++ b/common/cmd_nand.c
@@ -593,6 +593,7 @@  U_BOOT_CMD(
 	"nand bad - show bad blocks\n"
 	"nand dump[.oob] off - dump page\n"
 	"nand scrub - really clean NAND erasing bad blocks (UNSAFE)\n"
+	"    takes the same options as erase\n"
 	"nand markbad off [...] - mark bad block(s) at offset (UNSAFE)\n"
 	"nand biterr off - make a bit error at offset (UNSAFE)"
 #ifdef CONFIG_CMD_NAND_LOCK_UNLOCK