diff mbox

[U-Boot] exynos: video: Enable stdout env var backward compatibility for LCD

Message ID 1484586923-12204-1-git-send-email-javier@osg.samsung.com
State Accepted
Commit 3296eeff8ae064a788d52325fcd4ce1fdf52ee06
Delegated to: Minkyu Kang
Headers show

Commit Message

Javier Martinez Canillas Jan. 16, 2017, 5:15 p.m. UTC
Commit bb5930d5c97f ("exynos: video: Convert several boards to driver
model for video") converted the Exynos Chromebooks machines to use DM
for video, but this breaks backward compatibility with the stdout env
var since now stdout is expected to be "vidconsole" instead of "lcd".

This causes display to not work when updating u-boot on these boards
if the old stdout env var is used. Since these are consumer devices,
there's no easy way to have a serial console so users may be confused
thinking that u-boot failed to boot, or in the best case will need to
update the stdout env var blindly to make the display to work again.

There's a CONFIG_VIDCONSOLE_AS_LCD config option to workaround this,
so enable it in the Chromebooks' default configuration files to allow
users to change their stdout env var before the workaround is removed.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 configs/peach-pi_defconfig  | 1 +
 configs/peach-pit_defconfig | 1 +
 configs/snow_defconfig      | 1 +
 configs/spring_defconfig    | 1 +
 4 files changed, 4 insertions(+)

Comments

Minkyu Kang Jan. 18, 2017, 5:22 a.m. UTC | #1
On Tuesday, 17 January 2017, Javier Martinez Canillas <
javier@osg.samsung.com> wrote:

> Commit bb5930d5c97f ("exynos: video: Convert several boards to driver
> model for video") converted the Exynos Chromebooks machines to use DM
> for video, but this breaks backward compatibility with the stdout env
> var since now stdout is expected to be "vidconsole" instead of "lcd".
>
> This causes display to not work when updating u-boot on these boards
> if the old stdout env var is used. Since these are consumer devices,
> there's no easy way to have a serial console so users may be confused
> thinking that u-boot failed to boot, or in the best case will need to
> update the stdout env var blindly to make the display to work again.
>
> There's a CONFIG_VIDCONSOLE_AS_LCD config option to workaround this,
> so enable it in the Chromebooks' default configuration files to allow
> users to change their stdout env var before the workaround is removed.
>
> Suggested-by: Simon Glass <sjg@chromium.org <javascript:;>>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com
> <javascript:;>>
>
> ---
>
>  configs/peach-pi_defconfig  | 1 +
>  configs/peach-pit_defconfig | 1 +
>  configs/snow_defconfig      | 1 +
>  configs/spring_defconfig    | 1 +
>  4 files changed, 4 insertions(+)
>
> diff --git a/configs/peach-pi_defconfig b/configs/peach-pi_defconfig
> index ef0211842138..fb933efc5a9c 100644
> --- a/configs/peach-pi_defconfig
> +++ b/configs/peach-pi_defconfig
> @@ -60,5 +60,6 @@ CONFIG_DISPLAY=y
>  CONFIG_VIDEO_BRIDGE=y
>  CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
>  CONFIG_LCD=y
> +CONFIG_VIDCONSOLE_AS_LCD=y
>  CONFIG_TPM=y
>  CONFIG_ERRNO_STR=y
> diff --git a/configs/peach-pit_defconfig b/configs/peach-pit_defconfig
> index 14fe00eb2a4d..cbac99dd8362 100644
> --- a/configs/peach-pit_defconfig
> +++ b/configs/peach-pit_defconfig
> @@ -60,5 +60,6 @@ CONFIG_DISPLAY=y
>  CONFIG_VIDEO_BRIDGE=y
>  CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
>  CONFIG_LCD=y
> +CONFIG_VIDCONSOLE_AS_LCD=y
>  CONFIG_TPM=y
>  CONFIG_ERRNO_STR=y
> diff --git a/configs/snow_defconfig b/configs/snow_defconfig
> index 47b498b6b2d9..ea0412a73f06 100644
> --- a/configs/snow_defconfig
> +++ b/configs/snow_defconfig
> @@ -68,5 +68,6 @@ CONFIG_VIDEO_BRIDGE=y
>  CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
>  CONFIG_VIDEO_BRIDGE_NXP_PTN3460=y
>  CONFIG_LCD=y
> +CONFIG_VIDCONSOLE_AS_LCD=y
>  CONFIG_TPM=y
>  CONFIG_ERRNO_STR=y
> diff --git a/configs/spring_defconfig b/configs/spring_defconfig
> index 4a782c80da8f..d20ac0b0e8ce 100644
> --- a/configs/spring_defconfig
> +++ b/configs/spring_defconfig
> @@ -67,5 +67,6 @@ CONFIG_DISPLAY=y
>  CONFIG_VIDEO_BRIDGE=y
>  CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
>  CONFIG_LCD=y
> +CONFIG_VIDCONSOLE_AS_LCD=y
>  CONFIG_TPM=y
>  CONFIG_ERRNO_STR=y
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de <javascript:;>
> http://lists.denx.de/mailman/listinfo/u-boot
>

 applied to u-boot-samsung

Thanks
diff mbox

Patch

diff --git a/configs/peach-pi_defconfig b/configs/peach-pi_defconfig
index ef0211842138..fb933efc5a9c 100644
--- a/configs/peach-pi_defconfig
+++ b/configs/peach-pi_defconfig
@@ -60,5 +60,6 @@  CONFIG_DISPLAY=y
 CONFIG_VIDEO_BRIDGE=y
 CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
 CONFIG_LCD=y
+CONFIG_VIDCONSOLE_AS_LCD=y
 CONFIG_TPM=y
 CONFIG_ERRNO_STR=y
diff --git a/configs/peach-pit_defconfig b/configs/peach-pit_defconfig
index 14fe00eb2a4d..cbac99dd8362 100644
--- a/configs/peach-pit_defconfig
+++ b/configs/peach-pit_defconfig
@@ -60,5 +60,6 @@  CONFIG_DISPLAY=y
 CONFIG_VIDEO_BRIDGE=y
 CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
 CONFIG_LCD=y
+CONFIG_VIDCONSOLE_AS_LCD=y
 CONFIG_TPM=y
 CONFIG_ERRNO_STR=y
diff --git a/configs/snow_defconfig b/configs/snow_defconfig
index 47b498b6b2d9..ea0412a73f06 100644
--- a/configs/snow_defconfig
+++ b/configs/snow_defconfig
@@ -68,5 +68,6 @@  CONFIG_VIDEO_BRIDGE=y
 CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
 CONFIG_VIDEO_BRIDGE_NXP_PTN3460=y
 CONFIG_LCD=y
+CONFIG_VIDCONSOLE_AS_LCD=y
 CONFIG_TPM=y
 CONFIG_ERRNO_STR=y
diff --git a/configs/spring_defconfig b/configs/spring_defconfig
index 4a782c80da8f..d20ac0b0e8ce 100644
--- a/configs/spring_defconfig
+++ b/configs/spring_defconfig
@@ -67,5 +67,6 @@  CONFIG_DISPLAY=y
 CONFIG_VIDEO_BRIDGE=y
 CONFIG_VIDEO_BRIDGE_PARADE_PS862X=y
 CONFIG_LCD=y
+CONFIG_VIDCONSOLE_AS_LCD=y
 CONFIG_TPM=y
 CONFIG_ERRNO_STR=y