diff mbox

SDL2 depends on MMU (fork)

Message ID 1483609518-7756-1-git-send-email-guillaume.gardet@oliseo.fr
State Changes Requested
Headers show

Commit Message

Guillaume GARDET Jan. 5, 2017, 9:45 a.m. UTC
Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa

Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
---
 package/sdl2/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Baruch Siach Jan. 5, 2017, 11:42 a.m. UTC | #1
Hi Guillaume,

On Thu, Jan 05, 2017 at 10:45:18AM +0100, Guillaume GARDET wrote:
> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> ---
>  package/sdl2/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
> index b73611d..30d5c1a 100644
> --- a/package/sdl2/Config.in
> +++ b/package/sdl2/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_SDL2
>  	bool "sdl2"
>  	depends on !BR2_STATIC_LIBS
> +	depends on BR2_USE_MMU # fork()

You need to propagate this dependency to config symbols that select 
BR2_PACKAGE_SDL2, BR2_PACKAGE_FFMPEG_FFPLAY and BR2_PACKAGE_STELLA. See 
section 17.2.3 in the manual[1] for an explanation.

[1] http://nightly.buildroot.org/manual.html#_config_files

>  	help
>  	  Simple DirectMedia Layer 2 - SDL2 is a library that allows
>  	  programs portable low level access to a video framebuffer,

baruch
Romain Naour Jan. 5, 2017, 10:29 p.m. UTC | #2
Hi Guillaume,

Le 05/01/2017 à 12:42, Baruch Siach a écrit :
> Hi Guillaume,
> 
> On Thu, Jan 05, 2017 at 10:45:18AM +0100, Guillaume GARDET wrote:
>> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> ---
>>  package/sdl2/Config.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
>> index b73611d..30d5c1a 100644
>> --- a/package/sdl2/Config.in
>> +++ b/package/sdl2/Config.in
>> @@ -1,6 +1,7 @@
>>  config BR2_PACKAGE_SDL2
>>  	bool "sdl2"
>>  	depends on !BR2_STATIC_LIBS
>> +	depends on BR2_USE_MMU # fork()

It's actually BR2_PACKAGE_SDL2_X11 option that use fork().
If you disable it, SDL2 package build fine with this configuration.

Best regards,
Romain

> 
> You need to propagate this dependency to config symbols that select 
> BR2_PACKAGE_SDL2, BR2_PACKAGE_FFMPEG_FFPLAY and BR2_PACKAGE_STELLA. See 
> section 17.2.3 in the manual[1] for an explanation.
> 
> [1] http://nightly.buildroot.org/manual.html#_config_files
> 
>>  	help
>>  	  Simple DirectMedia Layer 2 - SDL2 is a library that allows
>>  	  programs portable low level access to a video framebuffer,
> 
> baruch
>
Baruch Siach Jan. 6, 2017, 6:05 a.m. UTC | #3
Hi Romain,

On Thu, Jan 05, 2017 at 11:29:44PM +0100, Romain Naour wrote:
> Le 05/01/2017 à 12:42, Baruch Siach a écrit :
> > On Thu, Jan 05, 2017 at 10:45:18AM +0100, Guillaume GARDET wrote:
> >> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
> >>
> >> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> >> ---
> >>  package/sdl2/Config.in | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
> >> index b73611d..30d5c1a 100644
> >> --- a/package/sdl2/Config.in
> >> +++ b/package/sdl2/Config.in
> >> @@ -1,6 +1,7 @@
> >>  config BR2_PACKAGE_SDL2
> >>  	bool "sdl2"
> >>  	depends on !BR2_STATIC_LIBS
> >> +	depends on BR2_USE_MMU # fork()
> 
> It's actually BR2_PACKAGE_SDL2_X11 option that use fork().
> If you disable it, SDL2 package build fine with this configuration.

In this case there is no need to propagate the dependency, since no symbol 
selects BR2_PACKAGE_SDL2_X11.

Thanks,
baruch

> > You need to propagate this dependency to config symbols that select 
> > BR2_PACKAGE_SDL2, BR2_PACKAGE_FFMPEG_FFPLAY and BR2_PACKAGE_STELLA. See 
> > section 17.2.3 in the manual[1] for an explanation.
> > 
> > [1] http://nightly.buildroot.org/manual.html#_config_files
> > 
> >>  	help
> >>  	  Simple DirectMedia Layer 2 - SDL2 is a library that allows
> >>  	  programs portable low level access to a video framebuffer,
diff mbox

Patch

diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
index b73611d..30d5c1a 100644
--- a/package/sdl2/Config.in
+++ b/package/sdl2/Config.in
@@ -1,6 +1,7 @@ 
 config BR2_PACKAGE_SDL2
 	bool "sdl2"
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_USE_MMU # fork()
 	help
 	  Simple DirectMedia Layer 2 - SDL2 is a library that allows
 	  programs portable low level access to a video framebuffer,