| Message ID | 1481030019-31854-2-git-send-email-madalin.bucur@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Dec 06, 2016 at 03:13:38PM +0200, Madalin Bucur wrote: > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > --- > arch/powerpc/boot/dts/fsl/t1024qds.dts | 29 +++++++++++++++++++++++++++++ > arch/powerpc/boot/dts/fsl/t1024rdb.dts | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 62 insertions(+) So, in patch 1/3 you add qman and bman nodes to t1023si-post.dtsi and call it "add QMan and BMan portal nodes on t1023rdb" as if it were board-specific (the only board-specific part is the reserved-memory nodes, not the portals). Then, in this patch you only touch board-specific files, and label it "add QMan and BMan portal nodes on t1024"... > diff --git a/arch/powerpc/boot/dts/fsl/t1024rdb.dts b/arch/powerpc/boot/dts/fsl/t1024rdb.dts > index 302cdd2..73a6453 100644 > --- a/arch/powerpc/boot/dts/fsl/t1024rdb.dts > +++ b/arch/powerpc/boot/dts/fsl/t1024rdb.dts > @@ -41,6 +41,31 @@ > #size-cells = <2>; > interrupt-parent = <&mpic>; > > + aliases { > + sg_2500_aqr105_phy4 = &sg_2500_aqr105_phy4; > + }; What does this have to do with the qman and bman portal nodes? Why is this alias needed? -Scott
> From: Scott Wood [mailto:oss@buserror.net] > Sent: Wednesday, December 07, 2016 2:59 AM > > On Tue, Dec 06, 2016 at 03:13:38PM +0200, Madalin Bucur wrote: > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > > --- > > arch/powerpc/boot/dts/fsl/t1024qds.dts | 29 > +++++++++++++++++++++++++++++ > > arch/powerpc/boot/dts/fsl/t1024rdb.dts | 33 > +++++++++++++++++++++++++++++++++ > > 2 files changed, 62 insertions(+) > > So, in patch 1/3 you add qman and bman nodes to t1023si-post.dtsi and > call it "add QMan and BMan portal nodes on t1023rdb" as if it were > board-specific (the only board-specific part is the reserved-memory > nodes, not the portals). > > Then, in this patch you only touch board-specific files, and label it > "add QMan and BMan portal nodes on t1024"... That needs fixing... > > diff --git a/arch/powerpc/boot/dts/fsl/t1024rdb.dts > b/arch/powerpc/boot/dts/fsl/t1024rdb.dts > > index 302cdd2..73a6453 100644 > > --- a/arch/powerpc/boot/dts/fsl/t1024rdb.dts > > +++ b/arch/powerpc/boot/dts/fsl/t1024rdb.dts > > @@ -41,6 +41,31 @@ > > #size-cells = <2>; > > interrupt-parent = <&mpic>; > > > > + aliases { > > + sg_2500_aqr105_phy4 = &sg_2500_aqr105_phy4; > > + }; > > What does this have to do with the qman and bman portal nodes? Why is > this alias needed? > > -Scott It's needed by u-boot, should be a separate patch. I'll resend. Madalin
diff --git a/arch/powerpc/boot/dts/fsl/t1024qds.dts b/arch/powerpc/boot/dts/fsl/t1024qds.dts index 772143d..d6858b7 100644 --- a/arch/powerpc/boot/dts/fsl/t1024qds.dts +++ b/arch/powerpc/boot/dts/fsl/t1024qds.dts @@ -41,6 +41,27 @@ #size-cells = <2>; interrupt-parent = <&mpic>; + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + bman_fbpr: bman-fbpr { + size = <0 0x1000000>; + alignment = <0 0x1000000>; + }; + + qman_fqd: qman-fqd { + size = <0 0x400000>; + alignment = <0 0x400000>; + }; + + qman_pfdr: qman-pfdr { + size = <0 0x2000000>; + alignment = <0 0x2000000>; + }; + }; + ifc: localbus@ffe124000 { reg = <0xf 0xfe124000 0 0x2000>; ranges = <0 0 0xf 0xe8000000 0x08000000 @@ -80,6 +101,14 @@ ranges = <0x00000000 0xf 0x00000000 0x01072000>; }; + bportals: bman-portals@ff4000000 { + ranges = <0x0 0xf 0xf4000000 0x2000000>; + }; + + qportals: qman-portals@ff6000000 { + ranges = <0x0 0xf 0xf6000000 0x2000000>; + }; + soc: soc@ffe000000 { ranges = <0x00000000 0xf 0xfe000000 0x1000000>; reg = <0xf 0xfe000000 0 0x00001000>; diff --git a/arch/powerpc/boot/dts/fsl/t1024rdb.dts b/arch/powerpc/boot/dts/fsl/t1024rdb.dts index 302cdd2..73a6453 100644 --- a/arch/powerpc/boot/dts/fsl/t1024rdb.dts +++ b/arch/powerpc/boot/dts/fsl/t1024rdb.dts @@ -41,6 +41,31 @@ #size-cells = <2>; interrupt-parent = <&mpic>; + aliases { + sg_2500_aqr105_phy4 = &sg_2500_aqr105_phy4; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + bman_fbpr: bman-fbpr { + size = <0 0x1000000>; + alignment = <0 0x1000000>; + }; + + qman_fqd: qman-fqd { + size = <0 0x400000>; + alignment = <0 0x400000>; + }; + + qman_pfdr: qman-pfdr { + size = <0 0x2000000>; + alignment = <0 0x2000000>; + }; + }; + ifc: localbus@ffe124000 { reg = <0xf 0xfe124000 0 0x2000>; ranges = <0 0 0xf 0xe8000000 0x08000000 @@ -82,6 +107,14 @@ ranges = <0x00000000 0xf 0x00000000 0x01072000>; }; + bportals: bman-portals@ff4000000 { + ranges = <0x0 0xf 0xf4000000 0x2000000>; + }; + + qportals: qman-portals@ff6000000 { + ranges = <0x0 0xf 0xf6000000 0x2000000>; + }; + soc: soc@ffe000000 { ranges = <0x00000000 0xf 0xfe000000 0x1000000>; reg = <0xf 0xfe000000 0 0x00001000>;
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- arch/powerpc/boot/dts/fsl/t1024qds.dts | 29 +++++++++++++++++++++++++++++ arch/powerpc/boot/dts/fsl/t1024rdb.dts | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+)