| Message ID | 1480414245-14034-5-git-send-email-peda@axentia.se |
|---|---|
| State | Superseded |
| Headers | show |
On 2016-11-29 11:10, Peter Rosin wrote: > +Example: > + mux: mux-controller { > + compatible = "mux-gpio"; > + #mux-control-cells = <0>; > + > + mux-gpios = <&pioA 0 GPIO_ACTIVE_HIGH>, > + <&pioA 1 GPIO_ACTIVE_HIGH>; > + }; > + > + adc-mux { > + compatible = "iio-mux"; > + io-channels = <&adc 0>; > + io-channel-names = "parent"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + mux-controls = <&mux>; > + > + sync@0 { > + reg = <0>; > + }; > + > + in@1 { > + reg = <1>; > + }; > + > + system-regulator@2 { > + reg = <2>; > + }; > + }; Hmmm, a more compact binding would be to just use an array of strings instead of a list of children for the mux channels, and use the array index as channel number, like so: adc-mux { compatible = "iio-mux"; io-channels = <&adc 0>; io-channel-names = "parent"; mux-controls = <&mux>; channels = "sync", "in", "system-regulator"; }; If you need to skip a low-number channel, you'd just put an empty string for that channel. If you need to skip channels at the end, just stop short. Can anyone think of any reason to add anything to the channel nodes that makes the string-array ineffective? If so, or if that comes up later, it could be optional and in that case you could look for the channels property first and then, if not present, iterate over child nodes. Opinions? I like it, it's a lot more compact... Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt b/Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt new file mode 100644 index 000000000000..403912631dcf --- /dev/null +++ b/Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt @@ -0,0 +1,51 @@ +IIO multiplexer bindings + +If a multiplexer is used to select which hardware signal is fed to +e.g. an ADC channel, these bindings describe that situation. + +Required properties: +- compatible : "iio-mux" +- io-channels : Channel node of the parent channel that has multiplexed + input. +- io-channel-names : Should be "parent". +- #address-cells = <1>; +- #size-cells = <0>; +- mux-controls : Mux controller node to use for operating the mux + +Required properties for iio-mux child nodes: +- reg : The multiplexer state as described in ../misc/mux-controller.txt + +For each iio-mux child, an iio channel will be created whose number will +match the mux controller state. + +Example: + mux: mux-controller { + compatible = "mux-gpio"; + #mux-control-cells = <0>; + + mux-gpios = <&pioA 0 GPIO_ACTIVE_HIGH>, + <&pioA 1 GPIO_ACTIVE_HIGH>; + }; + + adc-mux { + compatible = "iio-mux"; + io-channels = <&adc 0>; + io-channel-names = "parent"; + + #address-cells = <1>; + #size-cells = <0>; + + mux-controls = <&mux>; + + sync@0 { + reg = <0>; + }; + + in@1 { + reg = <1>; + }; + + system-regulator@2 { + reg = <2>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index dc7498682752..77045ae15865 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6234,6 +6234,12 @@ F: Documentation/ABI/testing/sysfs-bus-iio-adc-envelope-detector F: Documentation/devicetree/bindings/iio/adc/envelope-detector.txt F: drivers/iio/adc/envelope-detector.c +IIO MULTIPLEXER +M: Peter Rosin <peda@axentia.se> +L: linux-iio@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt + IIO SUBSYSTEM AND DRIVERS M: Jonathan Cameron <jic23@kernel.org> R: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Peter Rosin <peda@axentia.se> --- .../bindings/iio/multiplexer/iio-mux.txt | 51 ++++++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt