| Message ID | 20161126042459.1964-1-npiggin@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 2016/11/26 03:24PM, Nicholas Piggin wrote: > Switching from big endian to little endian can fail to regenerate > the crypto assembly properly. Switch to using standard form of > kbuild dependency checking (i.e., use FORCE and if_changed). > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Hi Nick, A similar patch is already in: https://mid.mail-archive.com/linux-crypto@vger.kernel.org/msg21855.html - Naveen
On Mon, 28 Nov 2016 13:51:36 +0530 "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote: > On 2016/11/26 03:24PM, Nicholas Piggin wrote: > > Switching from big endian to little endian can fail to regenerate > > the crypto assembly properly. Switch to using standard form of > > kbuild dependency checking (i.e., use FORCE and if_changed). > > > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > > Hi Nick, > A similar patch is already in: > https://mid.mail-archive.com/linux-crypto@vger.kernel.org/msg21855.html > > - Naveen > Hi Naveen, I didn't notice your patch, thanks for pointing it out. Thanks, Nick
diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile index b47da00..16ab2a0 100644 --- a/drivers/crypto/vmx/Makefile +++ b/drivers/crypto/vmx/Makefile @@ -1,6 +1,8 @@ obj-$(CONFIG_CRYPTO_DEV_VMX_ENCRYPT) += vmx-crypto.o vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o aes_cbc.o aes_ctr.o aes_xts.o ghash.o +targets += aesp8-ppc.S ghashp8-ppc.S + ifdef CONFIG_CPU_LITTLE_ENDIAN TARGET := linux-ppc64le else @@ -11,13 +13,13 @@ TARGET := linux-ppc64 endif endif -quiet_cmd_perl = PERL $@ +quiet_cmd_perl = PERL $@ cmd_perl = $(PERL) $(<) $(TARGET) > $(@) -$(src)/aesp8-ppc.S: $(src)/aesp8-ppc.pl - $(call cmd,perl) +$(src)/aesp8-ppc.S: $(src)/aesp8-ppc.pl FORCE + $(call if_changed,perl) -$(src)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl - $(call cmd,perl) +$(src)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl FORCE + $(call if_changed,perl) .PRECIOUS: $(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S
Switching from big endian to little endian can fail to regenerate the crypto assembly properly. Switch to using standard form of kbuild dependency checking (i.e., use FORCE and if_changed). Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- drivers/crypto/vmx/Makefile | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)