| Message ID | 1479124767-20165-1-git-send-email-akshay.adiga@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Monday, November 14, 2016 05:29:27 PM Akshay Adiga wrote: > lpstate_idx remains uninitialized in the case when elapsed_time > is greater than MAX_RAMP_DOWN_TIME. At the end of rampdown > global pstate should be equal to local pstate. > > Fixes: 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and > localpstate") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> > --- > drivers/cpufreq/powernv-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index c82304b..c5c5bc3 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -624,6 +624,7 @@ void gpstate_timer_handler(unsigned long data) > > if (gpstates->elapsed_time > MAX_RAMP_DOWN_TIME) { > gpstate_idx = pstate_to_idx(freq_data.pstate_id); > + lpstate_idx = gpstate_idx; > reset_gpstates(policy); > gpstates->highest_lpstate_idx = gpstate_idx; > } else { > Applied. Thanks, Rafael
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index c82304b..c5c5bc3 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -624,6 +624,7 @@ void gpstate_timer_handler(unsigned long data) if (gpstates->elapsed_time > MAX_RAMP_DOWN_TIME) { gpstate_idx = pstate_to_idx(freq_data.pstate_id); + lpstate_idx = gpstate_idx; reset_gpstates(policy); gpstates->highest_lpstate_idx = gpstate_idx; } else {
lpstate_idx remains uninitialized in the case when elapsed_time is greater than MAX_RAMP_DOWN_TIME. At the end of rampdown global pstate should be equal to local pstate. Fixes: 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and localpstate") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> --- drivers/cpufreq/powernv-cpufreq.c | 1 + 1 file changed, 1 insertion(+)