| Message ID | 20161113185453.29491-1-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 4c6a43de5a584e2496f78e252a83b0f7ec9bcfc8 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On Sun, 2016-11-13 at 19:54 +0100, Hans de Goede wrote: > And also remove it from scripts/config_whitelist.txt as the > Mele_M5_defconfig was the only one defining it. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Ian Campbell <ijc@hellion.org.uk>
On Mon, Nov 14, 2016 at 12:24 AM, Hans de Goede <hdegoede@redhat.com> wrote: > And also remove it from scripts/config_whitelist.txt as the > Mele_M5_defconfig was the only one defining it. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > configs/Mele_M5_defconfig | 2 +- > scripts/config_whitelist.txt | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configs/Mele_M5_defconfig b/configs/Mele_M5_defconfig > index fffc332..09addc5 100644 > --- a/configs/Mele_M5_defconfig > +++ b/configs/Mele_M5_defconfig > @@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y > CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_AHCI=y > -CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234" Still exist in boards.cfg? thanks!
Hi, On 21-11-16 11:05, Jagan Teki wrote: > On Mon, Nov 14, 2016 at 12:24 AM, Hans de Goede <hdegoede@redhat.com> wrote: >> And also remove it from scripts/config_whitelist.txt as the >> Mele_M5_defconfig was the only one defining it. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> configs/Mele_M5_defconfig | 2 +- >> scripts/config_whitelist.txt | 1 - >> 2 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/configs/Mele_M5_defconfig b/configs/Mele_M5_defconfig >> index fffc332..09addc5 100644 >> --- a/configs/Mele_M5_defconfig >> +++ b/configs/Mele_M5_defconfig >> @@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y >> CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5" >> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set >> CONFIG_AHCI=y >> -CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234" > > Still exist in boards.cfg? boards.cfg is generated for backward-compat with some scripts now a days, it is not part of the git repo. Regards, Hans
On Mon, Nov 21, 2016 at 3:36 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 21-11-16 11:05, Jagan Teki wrote: >> >> On Mon, Nov 14, 2016 at 12:24 AM, Hans de Goede <hdegoede@redhat.com> >> wrote: >>> >>> And also remove it from scripts/config_whitelist.txt as the >>> Mele_M5_defconfig was the only one defining it. >>> >>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>> --- >>> configs/Mele_M5_defconfig | 2 +- >>> scripts/config_whitelist.txt | 1 - >>> 2 files changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/configs/Mele_M5_defconfig b/configs/Mele_M5_defconfig >>> index fffc332..09addc5 100644 >>> --- a/configs/Mele_M5_defconfig >>> +++ b/configs/Mele_M5_defconfig >>> @@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y >>> CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5" >>> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set >>> CONFIG_AHCI=y >>> -CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234" >> >> >> Still exist in boards.cfg? > > > boards.cfg is generated for backward-compat with some > scripts now a days, it is not part of the git repo. OK, thought the same. Reviewed-by: Jagan Teki <jagan@openedev.com> thanks!
diff --git a/configs/Mele_M5_defconfig b/configs/Mele_M5_defconfig index fffc332..09addc5 100644 --- a/configs/Mele_M5_defconfig +++ b/configs/Mele_M5_defconfig @@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_AHCI=y -CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234" +CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC" CONFIG_SPL=y # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index d476367..5a471fe 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -4329,7 +4329,6 @@ CONFIG_STAMP_CF CONFIG_STANDALONE_LOAD_ADDR CONFIG_STATIC_BOARD_REV CONFIG_STATIC_RELA -CONFIG_STATUSLED CONFIG_STATUS_LED CONFIG_STD_DEVICES_SETTINGS CONFIG_STK52XX
And also remove it from scripts/config_whitelist.txt as the Mele_M5_defconfig was the only one defining it. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- configs/Mele_M5_defconfig | 2 +- scripts/config_whitelist.txt | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)