diff mbox

[U-Boot] ARM: OMAP3_LOGIC: Fix SPL Memory Map for Falcon Mode

Message ID 1479008617-32255-1-git-send-email-aford173@gmail.com
State Accepted
Commit b15e7c172709c0bbf10d8a229986581660d2b75f
Delegated to: Tom Rini
Headers show

Commit Message

Adam Ford Nov. 13, 2016, 3:43 a.m. UTC
The memory map defined in commit ("49c7303f0e52: OMAP3: Enable SPL
on omap3_logic) was used by a copy-paste of another board without
fully understanding how the map works in Falcon mode.  This patch
undoes the customization and uses the default SPL Memory Map
for OMAP3.

When building the uImage, set LOADADDR=0x82000000 and Falcon
mode should properly load.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Tom Rini Nov. 17, 2016, 10:16 p.m. UTC | #1
On Sat, Nov 12, 2016 at 09:43:37PM -0600, Adam Ford wrote:

> The memory map defined in commit ("49c7303f0e52: OMAP3: Enable SPL
> on omap3_logic) was used by a copy-paste of another board without
> fully understanding how the map works in Falcon mode.  This patch
> undoes the customization and uses the default SPL Memory Map
> for OMAP3.
> 
> When building the uImage, set LOADADDR=0x82000000 and Falcon
> mode should properly load.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/include/configs/omap3_logic.h b/include/configs/omap3_logic.h
> index 0827ebe..301d4b2 100644

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini Nov. 22, 2016, 2:58 a.m. UTC | #2
On Sat, Nov 12, 2016 at 09:43:37PM -0600, Adam Ford wrote:

> The memory map defined in commit ("49c7303f0e52: OMAP3: Enable SPL
> on omap3_logic) was used by a copy-paste of another board without
> fully understanding how the map works in Falcon mode.  This patch
> undoes the customization and uses the default SPL Memory Map
> for OMAP3.
> 
> When building the uImage, set LOADADDR=0x82000000 and Falcon
> mode should properly load.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> diff --git a/include/configs/omap3_logic.h b/include/configs/omap3_logic.h
> index 0827ebe..301d4b2 100644

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/include/configs/omap3_logic.h b/include/configs/omap3_logic.h
index 0827ebe..301d4b2 100644
--- a/include/configs/omap3_logic.h
+++ b/include/configs/omap3_logic.h
@@ -15,19 +15,6 @@ 
 
 #define CONFIG_NR_DRAM_BANKS	2	/* CS1 may or may not be populated */
 
-/*
- * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
- * 64 bytes before this address should be set aside for u-boot.img's
- * header. That is 0x800FFFC0--0x80100000 should not be used for any
- * other needs.  We use this rather than the inherited defines from
- * ti_armv7_common.h for backwards compatibility.
- */
-#define CONFIG_SYS_TEXT_BASE		0x80100000
-#define CONFIG_SPL_BSS_START_ADDR	0x80000000
-#define CONFIG_SPL_BSS_MAX_SIZE		(512 << 10)	/* 512 KB */
-#define CONFIG_SYS_SPL_MALLOC_START	0x80208000
-#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000
-
 #include <configs/ti_omap3_common.h>
 
 /*