diff mbox

[3/3] powerpc/fsl/dts: add FMan node for t1042d4rdb

Message ID 1478879598-3362-3-git-send-email-madalin.bucur@nxp.com (mailing list archive)
State Not Applicable
Delegated to: Scott Wood
Headers show

Commit Message

Madalin Bucur Nov. 11, 2016, 3:53 p.m. UTC
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 arch/powerpc/boot/dts/fsl/t1042d4rdb.dts | 47 ++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

Comments

Crystal Wood Nov. 15, 2016, 6:18 a.m. UTC | #1
On Fri, 2016-11-11 at 17:53 +0200, Madalin Bucur wrote:
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> ---
>  arch/powerpc/boot/dts/fsl/t1042d4rdb.dts | 47
> ++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
> b/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
> index 2a5a90d..8c0c318 100644
> --- a/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
> @@ -48,6 +48,53 @@
>  					"fsl,deepsleep-cpld";
>  		};
>  	};
> +	soc: soc@ffe000000 {

Please leave a blank line between nodes, especially here at the top level.

-Scott
Madalin Bucur Dec. 6, 2016, 12:56 p.m. UTC | #2
> From: Scott Wood [mailto:oss@buserror.net]

> Sent: Tuesday, November 15, 2016 8:19 AM

> 

> On Fri, 2016-11-11 at 17:53 +0200, Madalin Bucur wrote:

> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>

> > ---

> >  arch/powerpc/boot/dts/fsl/t1042d4rdb.dts | 47

> > ++++++++++++++++++++++++++++++++

> >  1 file changed, 47 insertions(+)

> >

> > diff --git a/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts

> > b/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts

> > index 2a5a90d..8c0c318 100644

> > --- a/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts

> > +++ b/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts

> > @@ -48,6 +48,53 @@

> >  					"fsl,deepsleep-cpld";

> >  		};

> >  	};

> > +	soc: soc@ffe000000 {

> 

> Please leave a blank line between nodes, especially here at the top level.

> 

> -Scott


I missed your feedback, will send a v2.

Thanks,
Madalin
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts b/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
index 2a5a90d..8c0c318 100644
--- a/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t1042d4rdb.dts
@@ -48,6 +48,53 @@ 
 					"fsl,deepsleep-cpld";
 		};
 	};
+	soc: soc@ffe000000 {
+		fman0: fman@400000 {
+			ethernet@e0000 {
+				phy-handle = <&phy_sgmii_0>;
+				phy-connection-type = "sgmii";
+			};
+
+			ethernet@e2000 {
+				phy-handle = <&phy_sgmii_1>;
+				phy-connection-type = "sgmii";
+			};
+
+			ethernet@e4000 {
+				phy-handle = <&phy_sgmii_2>;
+				phy-connection-type = "sgmii";
+			};
+
+			ethernet@e6000 {
+				phy-handle = <&phy_rgmii_0>;
+				phy-connection-type = "rgmii";
+			};
+
+			ethernet@e8000 {
+				phy-handle = <&phy_rgmii_1>;
+				phy-connection-type = "rgmii";
+			};
+
+			mdio0: mdio@fc000 {
+				phy_sgmii_0: ethernet-phy@02 {
+					reg = <0x02>;
+				};
+				phy_sgmii_1: ethernet-phy@03 {
+					reg = <0x03>;
+				};
+				phy_sgmii_2: ethernet-phy@01 {
+					reg = <0x01>;
+				};
+				phy_rgmii_0: ethernet-phy@04 {
+					reg = <0x04>;
+				};
+				phy_rgmii_1: ethernet-phy@05 {
+					reg = <0x05>;
+				};
+			};
+		};
+	};
+
 };
 
 #include "t1042si-post.dtsi"