diff mbox

[U-Boot] ARM: zynq: Extend picozed board support

Message ID CALtfCQYdahnHHHbYueVnoAmJY80MZY8eXwj53RLK5P6dNh+VPQ@mail.gmail.com
State Accepted
Delegated to: Michal Simek
Headers show

Commit Message

Oscar Gomez Fuente Oct. 17, 2016, 3:33 p.m. UTC 
Ok Michal,

Then you're suggesting change the zynq-picozed.dts file to:


And add a new dts file with the configuration of the PizoZed FMC Carrier V2
(in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
example: zynq-picozed-fmc-v2.dts

*
 * Avnet PicoZed FMC carrier V2 DTS
 *
 * Copyright (C) 2015 Xilinx, Inc.
 *
 * SPDX-License-Identifier: GPL-2.0+
 */
/dts-v1/;
#include "zynq-picozed.dts"

/ {
compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";

aliases {
mmc0 = &sdhci0;
};
};

&sdhci0 {
u-boot,dm-pre-reloc;
status = "okay";
};

Do you think the is the best way?


Best regards.

Oscar Gomez Fuente

On 17 October 2016 at 16:36, Michal Simek <michal.simek@xilinx.com> wrote:

> On 17.10.2016 16:03, Oscar Gomez Fuente wrote:
> > Hi everyone,
> >
> > Sorry for the errors, I know is a very simple patch but it's my first
> time.
> >
> > ------------------------------------------------------------
> ------------------------------
> >> Add missing DT nodes.
> >>
> >> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> >> ---
> >>  arch/arm/dts/zynq-picozed.dts | 20 ++++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>
> >> diff --git a/arch/arm/dts/zynq-picozed.dts
> b/arch/arm/dts/zynq-picozed.dts
> >> index 3408df8..5f703a2 100644
> >> --- a/arch/arm/dts/zynq-picozed.dts
> >> +++ b/arch/arm/dts/zynq-picozed.dts
> >> @@ -26,3 +26,23 @@
> >>       u-boot,dm-pre-reloc;
> >>       status = "okay";
> >>  };
> >> +
> >
> > please also extended aliases list.
> > ------------------------------------------------------------
> ------------------------------
> > -> Ok, Understood.
> >
> > ------------------------------------------------------------
> ------------------------------
> >> +&gem0 {
> >> +     status = "okay";
> >> +     phy-mode = "rgmii-id";
> >> +     phy-handle = <&ethernet_phy>;
> >> +
> >> +     ethernet_phy: ethernet-phy@0 {
> >> +             reg = <0>;
> >
> > I expect that this is on board 88e1512
> > ------------------------------------------------------------
> ------------------------------
> > -> Yes, this is on board 88e1512. Do I have to modify anything? I think
> > that's good, isn't it?
>
> nope.
>
> >
> > ------------------------------------------------------------
> ------------------------------
> >> +     };
> >> +};
> >> +
> >> +&qspi {
> >> +     u-boot,dm-pre-reloc;
> >> +     status = "okay";
> >> +     };
> >
> > wrong indentation here.
> > ------------------------------------------------------------
> ------------------------------
> > -> Ok, sorry.
> >
> > ------------------------------------------------------------
> ------------------------------
> >> +
> >> +&sdhci0 {
> >
> > is this sd0 or sd1 hard IP? I expect that this is emmc right?
> > ------------------------------------------------------------
> ------------------------------
> > -> sdhci0 is sd0 IP, the Sd Card on the PicoZed FMC Carrier.
>
>
> Then this shouldn't be the part of this file. picozed is SOM and you
> should describe all stuff which are just on this module.
> If you want to support Picozed with any carrier board you should
> describe it separately. The best carrier and include picozed dts.
>
>
> >
> >> +     u-boot,dm-pre-reloc;
> >> +     status = "okay";
> >> +};
> >>
> >
> > If everything is ok now, I'll send the patch to mainline mailing list
> > instead of xilinx one.
>
> I have changed emails.
>
> >
> >
> > Another question: Do you know if there is any perl script to check dts
> > files before sending it? I've run the ./scripts/checkpatch.pl to check
> the
> > arch/arm/dts/zynq-picozed.dts file and I didn't get any error.
>
> checkpatch is not designed to parse DTS files and I am not sure if there
> is any parser.
>
> Thanks,
> Michal
>

Comments

Moritz Fischer Oct. 17, 2016, 9:28 p.m. UTC | #1 
Hi Oscar,

On Mon, Oct 17, 2016 at 5:33 PM, Oscar Gomez Fuente
<oscargomezf@gmail.com> wrote:
> Ok Michal,
>
> Then you're suggesting change the zynq-picozed.dts file to:

If you're planning to include this into others, make it a .dtsi file.

>
> diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
> index 3408df8..d8ed298 100644
> --- a/arch/arm/dts/zynq-picozed.dts
> +++ b/arch/arm/dts/zynq-picozed.dts
> @@ -14,6 +14,8 @@
>
>         aliases {
>                 serial0 = &uart1;
> +               spi0 = &qspi;
> +               ethernet0 = &gem0;
>         };
>
>         memory {
> @@ -26,3 +28,18 @@
>         u-boot,dm-pre-reloc;
>         status = "okay";
>  };
> +
> +&qspi {
> +       u-boot,dm-pre-reloc;
> +       status = "okay";
> +};
> +
> +&gem0 {
> +       status = "okay";
> +       phy-mode = "rgmii-id";
> +       phy-handle = <&ethernet_phy>;
> +
> +       ethernet_phy: ethernet-phy@0 {
> +               reg = <0>;
> +       };
> +};
>
> And add a new dts file with the configuration of the PizoZed FMC Carrier V2
> (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
> example: zynq-picozed-fmc-v2.dts
>
> *
>  * Avnet PicoZed FMC carrier V2 DTS
>  *
>  * Copyright (C) 2015 Xilinx, Inc.
>  *
>  * SPDX-License-Identifier: GPL-2.0+
>  */
> /dts-v1/;
> #include "zynq-picozed.dts"

should be a .dtsi file then.
>
> / {
> compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
> aliases {
> mmc0 = &sdhci0;
> };
> };
>
> &sdhci0 {
> u-boot,dm-pre-reloc;
> status = "okay";
> };
>
> Do you think the is the best way?
>
>
> Best regards.
>
> Oscar Gomez Fuente
>
> On 17 October 2016 at 16:36, Michal Simek <michal.simek@xilinx.com> wrote:
>
>> On 17.10.2016 16:03, Oscar Gomez Fuente wrote:
>> > Hi everyone,
>> >
>> > Sorry for the errors, I know is a very simple patch but it's my first
>> time.
>> >
>> > ------------------------------------------------------------
>> ------------------------------
>> >> Add missing DT nodes.
>> >>
>> >> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
>> >> ---
>> >>  arch/arm/dts/zynq-picozed.dts | 20 ++++++++++++++++++++
>> >>  1 file changed, 20 insertions(+)
>> >>
>> >> diff --git a/arch/arm/dts/zynq-picozed.dts
>> b/arch/arm/dts/zynq-picozed.dts
>> >> index 3408df8..5f703a2 100644
>> >> --- a/arch/arm/dts/zynq-picozed.dts
>> >> +++ b/arch/arm/dts/zynq-picozed.dts
>> >> @@ -26,3 +26,23 @@
>> >>       u-boot,dm-pre-reloc;
>> >>       status = "okay";
>> >>  };
>> >> +
>> >
>> > please also extended aliases list.
>> > ------------------------------------------------------------
>> ------------------------------
>> > -> Ok, Understood.
>> >
>> > ------------------------------------------------------------
>> ------------------------------
>> >> +&gem0 {
>> >> +     status = "okay";
>> >> +     phy-mode = "rgmii-id";
>> >> +     phy-handle = <&ethernet_phy>;
>> >> +
>> >> +     ethernet_phy: ethernet-phy@0 {
>> >> +             reg = <0>;
>> >
>> > I expect that this is on board 88e1512
>> > ------------------------------------------------------------
>> ------------------------------
>> > -> Yes, this is on board 88e1512. Do I have to modify anything? I think
>> > that's good, isn't it?
>>
>> nope.
>>
>> >
>> > ------------------------------------------------------------
>> ------------------------------
>> >> +     };
>> >> +};
>> >> +
>> >> +&qspi {
>> >> +     u-boot,dm-pre-reloc;
>> >> +     status = "okay";
>> >> +     };
>> >
>> > wrong indentation here.
>> > ------------------------------------------------------------
>> ------------------------------
>> > -> Ok, sorry.
>> >
>> > ------------------------------------------------------------
>> ------------------------------
>> >> +
>> >> +&sdhci0 {
>> >
>> > is this sd0 or sd1 hard IP? I expect that this is emmc right?
>> > ------------------------------------------------------------
>> ------------------------------
>> > -> sdhci0 is sd0 IP, the Sd Card on the PicoZed FMC Carrier.
>>
>>
>> Then this shouldn't be the part of this file. picozed is SOM and you
>> should describe all stuff which are just on this module.
>> If you want to support Picozed with any carrier board you should
>> describe it separately. The best carrier and include picozed dts.
>>
>>
>> >
>> >> +     u-boot,dm-pre-reloc;
>> >> +     status = "okay";
>> >> +};
>> >>
>> >
>> > If everything is ok now, I'll send the patch to mainline mailing list
>> > instead of xilinx one.
>>
>> I have changed emails.
>>
>> >
>> >
>> > Another question: Do you know if there is any perl script to check dts
>> > files before sending it? I've run the ./scripts/checkpatch.pl to check
>> the
>> > arch/arm/dts/zynq-picozed.dts file and I didn't get any error.
>>
>> checkpatch is not designed to parse DTS files and I am not sure if there
>> is any parser.
>>
>> Thanks,
>> Michal
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Thanks,

Moritz
Michal Simek Oct. 18, 2016, 6:57 a.m. UTC | #2 
On 17.10.2016 23:28, Moritz Fischer wrote:
> Hi Oscar,
> 
> On Mon, Oct 17, 2016 at 5:33 PM, Oscar Gomez Fuente
> <oscargomezf@gmail.com> wrote:
>> Ok Michal,
>>
>> Then you're suggesting change the zynq-picozed.dts file to:
> 
> If you're planning to include this into others, make it a .dtsi file.
> 
>>
>> diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
>> index 3408df8..d8ed298 100644
>> --- a/arch/arm/dts/zynq-picozed.dts
>> +++ b/arch/arm/dts/zynq-picozed.dts
>> @@ -14,6 +14,8 @@
>>
>>         aliases {
>>                 serial0 = &uart1;
>> +               spi0 = &qspi;
>> +               ethernet0 = &gem0;
>>         };
>>
>>         memory {
>> @@ -26,3 +28,18 @@
>>         u-boot,dm-pre-reloc;
>>         status = "okay";
>>  };
>> +
>> +&qspi {
>> +       u-boot,dm-pre-reloc;
>> +       status = "okay";
>> +};
>> +
>> +&gem0 {
>> +       status = "okay";
>> +       phy-mode = "rgmii-id";
>> +       phy-handle = <&ethernet_phy>;
>> +
>> +       ethernet_phy: ethernet-phy@0 {
>> +               reg = <0>;
>> +       };
>> +};
>>
>> And add a new dts file with the configuration of the PizoZed FMC Carrier V2
>> (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
>> example: zynq-picozed-fmc-v2.dts
>>
>> *
>>  * Avnet PicoZed FMC carrier V2 DTS
>>  *
>>  * Copyright (C) 2015 Xilinx, Inc.
>>  *
>>  * SPDX-License-Identifier: GPL-2.0+
>>  */
>> /dts-v1/;
>> #include "zynq-picozed.dts"
> 
> should be a .dtsi file then.


If you can't use picozed without carrier board then zynq-picozed should
be dtsi.

Thanks,
Michal
Michal Simek Oct. 18, 2016, 7 a.m. UTC | #3 
On 17.10.2016 17:33, Oscar Gomez Fuente wrote:
> Ok Michal,
> 
> Then you're suggesting change the zynq-picozed.dts file to:

dtsi.

> 
> diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
> index 3408df8..d8ed298 100644
> --- a/arch/arm/dts/zynq-picozed.dts
> +++ b/arch/arm/dts/zynq-picozed.dts
> @@ -14,6 +14,8 @@
> 
>         aliases {
>                 serial0 = &uart1;
> +               spi0 = &qspi;
> +               ethernet0 = &gem0;
>         };
> 
>         memory {
> @@ -26,3 +28,18 @@
>         u-boot,dm-pre-reloc;
>         status = "okay";
>  };
> +
> +&qspi {
> +       u-boot,dm-pre-reloc;
> +       status = "okay";
> +};

keep node names sorted.

> +
> +&gem0 {
> +       status = "okay";
> +       phy-mode = "rgmii-id";
> +       phy-handle = <&ethernet_phy>;
> +
> +       ethernet_phy: ethernet-phy@0 {
> +               reg = <0>;
> +       };
> +};
> 
> And add a new dts file with the configuration of the PizoZed FMC Carrier V2
> (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
> example: zynq-picozed-fmc-v2.dts
> 
> *
>  * Avnet PicoZed FMC carrier V2 DTS
>  *
>  * Copyright (C) 2015 Xilinx, Inc.
>  *
>  * SPDX-License-Identifier: GPL-2.0+
>  */
> /dts-v1/;

Depends how zynq-picozed.dtsi will look but this line above can be
already there.

> #include "zynq-picozed.dts"
> 
> / {
> compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";

here
"xlnx,zynq-picozed-fmc-v2", "xlnx,zynq-picozed", "xlnx,zynq-7000";


> 
> aliases {
> mmc0 = &sdhci0;
> };
> };
> 
> &sdhci0 {
> u-boot,dm-pre-reloc;
> status = "okay";
> };
> 
> Do you think the is the best way?

with changes above it looks reasonable.

Thanks,
Michal
Oscar Gomez Fuente Oct. 18, 2016, 7:28 a.m. UTC | #4 
Hi everyone,

In my opinion, use the picozed without a carrier board it doesn't make
 sense. You always are going to need a carrier board. Avnet has two models
the PicoZed FMC Carrier V2 and the PicoZed FMC Carrier V1. And the company
I'm working, it is going to desing a custom carrier board according to our
necessity.

So maybe, it's better to have only two .dts files. zynq-picozed-fmc-v2.dts
and zynq-picozed-fmc-v1.dts.

If we decide to have the zynq-picozed.dtsi and zynq-picozed-fmc-v2.dts,
we'll have to decide what hardware description is going to be in the
zynq-picozed-fmc-v2.dts and what hardware description is going to be
in zynq-picozed.dtsi.

for example the spi0 hw is in the picozed  board, but the SD (mmc0), eth0
(gem0) and serial0 (uart1) the HW is in the picoZed but the connectors are
in the PicoZed FMC Carrier V2, so It's a little bit confused if this HW
description has to be on the zynq-picozed.dtsi file or in the
zynq-picozed-fmc-v2.dts file. Do you know what I mean?

Please let me see you opinions about that.

Best regards.

[image: photo] Óscar Gómez Fuente
Electronic Engineer & Degree in Physical Sciences
Mobile: 659.28.97.90
Email: oscargomezf@gmail.com
Website: www.oscargomezf.com
<http://facebook.com/oscargomezf>  <http://plus.google.com/oscargomezf>
<http://us.linkedin.com/in/oscargomezf>
<http://twitter.com/oscargomezf_com>

On 18 October 2016 at 09:00, Michal Simek <michal.simek@xilinx.com> wrote:

> On 17.10.2016 17:33, Oscar Gomez Fuente wrote:
> > Ok Michal,
> >
> > Then you're suggesting change the zynq-picozed.dts file to:
>
> dtsi.
>
> >
> > diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.
> dts
> > index 3408df8..d8ed298 100644
> > --- a/arch/arm/dts/zynq-picozed.dts
> > +++ b/arch/arm/dts/zynq-picozed.dts
> > @@ -14,6 +14,8 @@
> >
> >         aliases {
> >                 serial0 = &uart1;
> > +               spi0 = &qspi;
> > +               ethernet0 = &gem0;
> >         };
> >
> >         memory {
> > @@ -26,3 +28,18 @@
> >         u-boot,dm-pre-reloc;
> >         status = "okay";
> >  };
> > +
> > +&qspi {
> > +       u-boot,dm-pre-reloc;
> > +       status = "okay";
> > +};
>
> keep node names sorted.
>
> > +
> > +&gem0 {
> > +       status = "okay";
> > +       phy-mode = "rgmii-id";
> > +       phy-handle = <&ethernet_phy>;
> > +
> > +       ethernet_phy: ethernet-phy@0 {
> > +               reg = <0>;
> > +       };
> > +};
> >
> > And add a new dts file with the configuration of the PizoZed FMC Carrier
> V2
> > (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
> > example: zynq-picozed-fmc-v2.dts
> >
> > *
> >  * Avnet PicoZed FMC carrier V2 DTS
> >  *
> >  * Copyright (C) 2015 Xilinx, Inc.
> >  *
> >  * SPDX-License-Identifier: GPL-2.0+
> >  */
> > /dts-v1/;
>
> Depends how zynq-picozed.dtsi will look but this line above can be
> already there.
>
> > #include "zynq-picozed.dts"
> >
> > / {
> > compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
> here
> "xlnx,zynq-picozed-fmc-v2", "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
>
> >
> > aliases {
> > mmc0 = &sdhci0;
> > };
> > };
> >
> > &sdhci0 {
> > u-boot,dm-pre-reloc;
> > status = "okay";
> > };
> >
> > Do you think the is the best way?
>
> with changes above it looks reasonable.
>
> Thanks,
> Michal
>
>
Oscar Gomez Fuente Oct. 18, 2016, 10:06 a.m. UTC | #5 
Hi everyone,

It seems to be that the mailbox of the email address
albert.u.boot@aribaud.net is quota exceeded, and all emails are rejected.

-----
Final-Recipient: rfc822; albert.u.boot@aribaud.net.rmap1.bookmyname.com
Original-Recipient: rfc822;albert.u.boot@aribaud.net
Action: failed
Status: 5.0.0
Remote-MTA: dns; 127.0.0.1
Diagnostic-Code: smtp; 552 4.2.2
    <albert.u.boot@aribaud.net.rmap1.bookmyname.com>: Mailbox full -- Quota
    exceeded
...
-----

could anyone inform about that please?

Best regards.


[image: photo] Óscar Gómez Fuente
Electronic Engineer & Degree in Physical Sciences
Mobile: 659.28.97.90
Email: oscargomezf@gmail.com
Website: www.oscargomezf.com
<http://facebook.com/oscargomezf>  <http://plus.google.com/oscargomezf>
<http://us.linkedin.com/in/oscargomezf>
<http://twitter.com/oscargomezf_com>

On 18 October 2016 at 09:00, Michal Simek <michal.simek@xilinx.com> wrote:

> On 17.10.2016 17:33, Oscar Gomez Fuente wrote:
> > Ok Michal,
> >
> > Then you're suggesting change the zynq-picozed.dts file to:
>
> dtsi.
>
> >
> > diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.
> dts
> > index 3408df8..d8ed298 100644
> > --- a/arch/arm/dts/zynq-picozed.dts
> > +++ b/arch/arm/dts/zynq-picozed.dts
> > @@ -14,6 +14,8 @@
> >
> >         aliases {
> >                 serial0 = &uart1;
> > +               spi0 = &qspi;
> > +               ethernet0 = &gem0;
> >         };
> >
> >         memory {
> > @@ -26,3 +28,18 @@
> >         u-boot,dm-pre-reloc;
> >         status = "okay";
> >  };
> > +
> > +&qspi {
> > +       u-boot,dm-pre-reloc;
> > +       status = "okay";
> > +};
>
> keep node names sorted.
>
> > +
> > +&gem0 {
> > +       status = "okay";
> > +       phy-mode = "rgmii-id";
> > +       phy-handle = <&ethernet_phy>;
> > +
> > +       ethernet_phy: ethernet-phy@0 {
> > +               reg = <0>;
> > +       };
> > +};
> >
> > And add a new dts file with the configuration of the PizoZed FMC Carrier
> V2
> > (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
> > example: zynq-picozed-fmc-v2.dts
> >
> > *
> >  * Avnet PicoZed FMC carrier V2 DTS
> >  *
> >  * Copyright (C) 2015 Xilinx, Inc.
> >  *
> >  * SPDX-License-Identifier: GPL-2.0+
> >  */
> > /dts-v1/;
>
> Depends how zynq-picozed.dtsi will look but this line above can be
> already there.
>
> > #include "zynq-picozed.dts"
> >
> > / {
> > compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
> here
> "xlnx,zynq-picozed-fmc-v2", "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
>
> >
> > aliases {
> > mmc0 = &sdhci0;
> > };
> > };
> >
> > &sdhci0 {
> > u-boot,dm-pre-reloc;
> > status = "okay";
> > };
> >
> > Do you think the is the best way?
>
> with changes above it looks reasonable.
>
> Thanks,
> Michal
>
>
Michal Simek Oct. 18, 2016, 1:34 p.m. UTC | #6 
Hi,

On 18.10.2016 09:28, Oscar Gomez Fuente wrote:
> Hi everyone,
> 
> In my opinion, use the picozed without a carrier board it doesn't make
>  sense. You always are going to need a carrier board. Avnet has two models
> the PicoZed FMC Carrier V2 and the PicoZed FMC Carrier V1. And the company
> I'm working, it is going to desing a custom carrier board according to our
> necessity.
> 
> So maybe, it's better to have only two .dts files. zynq-picozed-fmc-v2.dts
> and zynq-picozed-fmc-v1.dts.
> 
> If we decide to have the zynq-picozed.dtsi and zynq-picozed-fmc-v2.dts,
> we'll have to decide what hardware description is going to be in the
> zynq-picozed-fmc-v2.dts and what hardware description is going to be
> in zynq-picozed.dtsi.
> 
> for example the spi0 hw is in the picozed  board, but the SD (mmc0), eth0
> (gem0) and serial0 (uart1) the HW is in the picoZed but the connectors are
> in the PicoZed FMC Carrier V2, so It's a little bit confused if this HW
> description has to be on the zynq-picozed.dtsi file or in the
> zynq-picozed-fmc-v2.dts file. Do you know what I mean?
> 
> Please let me see you opinions about that.

I understand your concern. These SOMs are problematic and it is up2you
how you want to do it. My preference would be to add common stuff to
dtsi file and carried board stuff to dts file. If that configurations
have nothing in common then using just fmc dts is fine for me.
When ps7_init.* files are in place it should be visible how MIOs are
configured.

Thanks,
Michal
diff mbox

Patch

diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
index 3408df8..d8ed298 100644
--- a/arch/arm/dts/zynq-picozed.dts
+++ b/arch/arm/dts/zynq-picozed.dts
@@ -14,6 +14,8 @@ 

        aliases {
                serial0 = &uart1;
+               spi0 = &qspi;
+               ethernet0 = &gem0;
        };

        memory {
@@ -26,3 +28,18 @@ 
        u-boot,dm-pre-reloc;
        status = "okay";
 };
+
+&qspi {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&gem0 {
+       status = "okay";
+       phy-mode = "rgmii-id";
+       phy-handle = <&ethernet_phy>;
+
+       ethernet_phy: ethernet-phy@0 {
+               reg = <0>;
+       };
+};