diff mbox

[U-Boot,8/9] reset: declare fdtdec_phandle_args as struct to fix warning

Message ID 1475900731-10998-9-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit d9f5d99245a32d95ae6aeb89a4ed258f7d1cea97
Delegated to: Masahiro Yamada
Headers show

Commit Message

Masahiro Yamada Oct. 8, 2016, 4:25 a.m. UTC
The of_xlate() callback needs to know fdtdec_phandle_args is struct.

Otherwise, the following warning is displayed.

include/reset-uclass.h:40:11: warning: 'struct fdtdec_phandle_args'
declared inside parameter list
    struct fdtdec_phandle_args *args);
           ^
include/reset-uclass.h:40:11: warning: its scope is only this
definition or declaration, which is probably not what you want

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/reset-uclass.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Masahiro Yamada Oct. 8, 2016, 5:03 a.m. UTC | #1
If nobody is opposed, I want to include this patch in my series.

Without this, my reset controller driver would spit a warning.



2016-10-08 13:25 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> The of_xlate() callback needs to know fdtdec_phandle_args is struct.
>
> Otherwise, the following warning is displayed.
>
> include/reset-uclass.h:40:11: warning: 'struct fdtdec_phandle_args'
> declared inside parameter list
>     struct fdtdec_phandle_args *args);
>            ^
> include/reset-uclass.h:40:11: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  include/reset-uclass.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/reset-uclass.h b/include/reset-uclass.h
> index 50adeca..38c716f 100644
> --- a/include/reset-uclass.h
> +++ b/include/reset-uclass.h
> @@ -11,6 +11,7 @@
>
>  #include <reset.h>
>
> +struct fdtdec_phandle_args;
>  struct udevice;
>
>  /**
> --
> 1.9.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Simon Glass Oct. 13, 2016, 12:03 a.m. UTC | #2
On 7 October 2016 at 22:25, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The of_xlate() callback needs to know fdtdec_phandle_args is struct.
>
> Otherwise, the following warning is displayed.
>
> include/reset-uclass.h:40:11: warning: 'struct fdtdec_phandle_args'
> declared inside parameter list
>     struct fdtdec_phandle_args *args);
>            ^
> include/reset-uclass.h:40:11: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  include/reset-uclass.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/include/reset-uclass.h b/include/reset-uclass.h
index 50adeca..38c716f 100644
--- a/include/reset-uclass.h
+++ b/include/reset-uclass.h
@@ -11,6 +11,7 @@ 
 
 #include <reset.h>
 
+struct fdtdec_phandle_args;
 struct udevice;
 
 /**