Patchwork [1/2] UBUNTU: Fix a minor typo for the alsa build

login
register
mail settings
Submitter Stefan Bader
Date Oct. 15, 2010, 11:16 a.m.
Message ID <1287141390-11555-2-git-send-email-stefan.bader@canonical.com>
Download mbox | patch
Permalink /patch/67945/
State Accepted
Delegated to: Stefan Bader
Headers show

Comments

Stefan Bader - Oct. 15, 2010, 11:16 a.m.
Ignore: yes

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 debian/rules.d/2-binary-arch.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Stefan Bader - Oct. 15, 2010, 11:53 a.m.
On 10/15/2010 03:07 PM, David Henningsson wrote:
> On 2010-10-15 13:16, Stefan Bader wrote:
>> Ignore: yes
>>
>> Signed-off-by: Stefan Bader<stefan.bader@canonical.com>
>> ---
>>   debian/rules.d/2-binary-arch.mk |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
>> index a359bb2..dca77d4 100644
>> --- a/debian/rules.d/2-binary-arch.mk
>> +++ b/debian/rules.d/2-binary-arch.mk
>> @@ -123,7 +123,7 @@ ifeq ($(do_compat_wireless),true)
>>   	install --mode=0644 $(cwblddir)/udev/ubuntu/50-compat_firmware_$(abinum).rules $(cwpkgdir)/lib/udev/rules.d
>>   endif
>>
>> -ifeq ($(do_also),true)
>> +ifeq ($(do_alsa),true)
>>   	#
>>   	# Build the ALSA snapshot packages.
>>   	#
>> @@ -167,7 +167,7 @@ endif
>>   ifeq ($(do_compat_wireless),true)
>>   	tar -C $(builddir)/build-$*/compat-wireless-2.6 -chf - include | tar -C $(hdrdir) -xf -
>>   endif
>> -ifeq ($(do_also),true)
>> +ifeq ($(do_alsa),true)
>>   	for i in asm linux media sound; do \
>>   		tar -C $(builddir)/build-$*/alsa-driver/include -chf - $$i | tar -C $(hdrdir)/include -xf -; \
>>   	done
> 
> Sounds serious - could you elaborate on what this means; is there a bug 
> out there I should be aware of?
> 
Not really serious. This is just with the current code  in lbm you could flip
do_alsa to true and still would get no alsa package in lbm (which there is not
one right now)

Stefan
David Henningsson - Oct. 15, 2010, 1:07 p.m.
On 2010-10-15 13:16, Stefan Bader wrote:
> Ignore: yes
>
> Signed-off-by: Stefan Bader<stefan.bader@canonical.com>
> ---
>   debian/rules.d/2-binary-arch.mk |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index a359bb2..dca77d4 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -123,7 +123,7 @@ ifeq ($(do_compat_wireless),true)
>   	install --mode=0644 $(cwblddir)/udev/ubuntu/50-compat_firmware_$(abinum).rules $(cwpkgdir)/lib/udev/rules.d
>   endif
>
> -ifeq ($(do_also),true)
> +ifeq ($(do_alsa),true)
>   	#
>   	# Build the ALSA snapshot packages.
>   	#
> @@ -167,7 +167,7 @@ endif
>   ifeq ($(do_compat_wireless),true)
>   	tar -C $(builddir)/build-$*/compat-wireless-2.6 -chf - include | tar -C $(hdrdir) -xf -
>   endif
> -ifeq ($(do_also),true)
> +ifeq ($(do_alsa),true)
>   	for i in asm linux media sound; do \
>   		tar -C $(builddir)/build-$*/alsa-driver/include -chf - $$i | tar -C $(hdrdir)/include -xf -; \
>   	done

Sounds serious - could you elaborate on what this means; is there a bug 
out there I should be aware of?

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index a359bb2..dca77d4 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -123,7 +123,7 @@  ifeq ($(do_compat_wireless),true)
 	install --mode=0644 $(cwblddir)/udev/ubuntu/50-compat_firmware_$(abinum).rules $(cwpkgdir)/lib/udev/rules.d
 endif
 
-ifeq ($(do_also),true)
+ifeq ($(do_alsa),true)
 	#
 	# Build the ALSA snapshot packages.
 	#
@@ -167,7 +167,7 @@  endif
 ifeq ($(do_compat_wireless),true)
 	tar -C $(builddir)/build-$*/compat-wireless-2.6 -chf - include | tar -C $(hdrdir) -xf -
 endif
-ifeq ($(do_also),true)
+ifeq ($(do_alsa),true)
 	for i in asm linux media sound; do \
 		tar -C $(builddir)/build-$*/alsa-driver/include -chf - $$i | tar -C $(hdrdir)/include -xf -; \
 	done