diff mbox

[U-Boot,1/5] sandbox/fs: Free memory allocated by os_dirent_ls

Message ID 6065a33a1e8d425880e61443df06ec75@rwthex-w2-b.rwth-ad.de
State Accepted
Commit 86167089b71c6b701194604e3dc66a67c6ea076a
Delegated to: Simon Glass
Headers show

Commit Message

Stefan Brüns Oct. 1, 2016, 6:41 p.m. UTC
Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
---
 fs/sandbox/sandboxfs.c |  1 +
 include/os.h           | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

Comments

Simon Glass Oct. 3, 2016, 9:49 p.m. UTC | #1
On 1 October 2016 at 12:41, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
> ---
>  fs/sandbox/sandboxfs.c |  1 +
>  include/os.h           | 11 ++++++++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass Oct. 11, 2016, 12:29 a.m. UTC | #2
\On 3 October 2016 at 15:49, Simon Glass <sjg@chromium.org> wrote:
> On 1 October 2016 at 12:41, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
>> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
>> ---
>>  fs/sandbox/sandboxfs.c |  1 +
>>  include/os.h           | 11 ++++++++++-
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/fs/sandbox/sandboxfs.c b/fs/sandbox/sandboxfs.c
index 2703eed..cd10fd6 100644
--- a/fs/sandbox/sandboxfs.c
+++ b/fs/sandbox/sandboxfs.c
@@ -94,6 +94,7 @@  int sandbox_fs_ls(const char *dirname)
 		printf("%s %10lu %s\n", os_dirent_get_typename(node->type),
 		       node->size, node->name);
 	}
+	os_dirent_free(head);
 
 	return 0;
 }
diff --git a/include/os.h b/include/os.h
index 1782e50..049b248 100644
--- a/include/os.h
+++ b/include/os.h
@@ -215,9 +215,18 @@  struct os_dirent_node {
 int os_dirent_ls(const char *dirname, struct os_dirent_node **headp);
 
 /**
+ * Free directory list
+ *
+ * This frees a linked list containing a directory listing.
+ *
+ * @param node		Pointer to head of linked list
+ */
+void os_dirent_free(struct os_dirent_node *node);
+
+/**
  * Get the name of a directory entry type
  *
- * @param type		Type to cehck
+ * @param type		Type to check
  * @return string containing the name of that type, or "???" if none/invalid
  */
 const char *os_dirent_get_typename(enum os_dirent_t type);