| Message ID | 1475129895-22667-2-git-send-email-sriram.dash@nxp.com |
|---|---|
| State | Accepted |
| Commit | aee28716c651077bac042a96f4fb8fed8d26c305 |
| Delegated to: | York Sun |
| Headers | show |
On 09/28/2016 11:18 PM, Sriram Dash wrote: > Enables driver model flag CONFIG_DM_USB for LS2080A > platform defconfigs. > > Signed-off-by: Sriram Dash <sriram.dash@nxp.com> > --- > configs/ls2080aqds_SECURE_BOOT_defconfig | 1 + > configs/ls2080aqds_defconfig | 1 + > configs/ls2080aqds_nand_defconfig | 1 + > configs/ls2080aqds_qspi_defconfig | 1 + > configs/ls2080ardb_SECURE_BOOT_defconfig | 1 + > configs/ls2080ardb_defconfig | 1 + > configs/ls2080ardb_nand_defconfig | 2 ++ > 7 files changed, 8 insertions(+) Sriram, Please retest ls2080ardb_nand. It fails in my build. "undefined reference to `dm_scan_fdt_dev'" York
>From: york sun >Sent: Thursday, October 06, 2016 12:37 AM >To: Sriram Dash <sriram.dash@nxp.com>; u-boot@lists.denx.de >Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; >albert.u.boot@aribaud.net; Suresh Gupta <suresh.gupta@nxp.com> >Subject: Re: [PATCH 1/2] armv8: ls2080: Enable CONFIG_DM_USB in defconfigs > >On 09/28/2016 11:18 PM, Sriram Dash wrote: >> Enables driver model flag CONFIG_DM_USB for LS2080A platform >> defconfigs. >> >> Signed-off-by: Sriram Dash <sriram.dash@nxp.com> >> --- >> configs/ls2080aqds_SECURE_BOOT_defconfig | 1 + >> configs/ls2080aqds_defconfig | 1 + >> configs/ls2080aqds_nand_defconfig | 1 + >> configs/ls2080aqds_qspi_defconfig | 1 + >> configs/ls2080ardb_SECURE_BOOT_defconfig | 1 + >> configs/ls2080ardb_defconfig | 1 + >> configs/ls2080ardb_nand_defconfig | 2 ++ >> 7 files changed, 8 insertions(+) > >Sriram, > >Please retest ls2080ardb_nand. It fails in my build. > >"undefined reference to `dm_scan_fdt_dev'" > Hello York, As of now, nand boot is disfeatured and hence, the config is missing some features for the nand boot. For this case, as the device tree is not enabled, the function isn't compiled. Setting CONFIG_OF_CONTROL and CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb" will make it compile without errors. However, I will remove the the USB DM feature for nand in the next revision. >York
On 10/05/2016 11:03 PM, Sriram Dash wrote: >> From: york sun >> Sent: Thursday, October 06, 2016 12:37 AM >> To: Sriram Dash <sriram.dash@nxp.com>; u-boot@lists.denx.de >> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; >> albert.u.boot@aribaud.net; Suresh Gupta <suresh.gupta@nxp.com> >> Subject: Re: [PATCH 1/2] armv8: ls2080: Enable CONFIG_DM_USB in defconfigs >> >> On 09/28/2016 11:18 PM, Sriram Dash wrote: >>> Enables driver model flag CONFIG_DM_USB for LS2080A platform >>> defconfigs. >>> >>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com> >>> --- >>> configs/ls2080aqds_SECURE_BOOT_defconfig | 1 + >>> configs/ls2080aqds_defconfig | 1 + >>> configs/ls2080aqds_nand_defconfig | 1 + >>> configs/ls2080aqds_qspi_defconfig | 1 + >>> configs/ls2080ardb_SECURE_BOOT_defconfig | 1 + >>> configs/ls2080ardb_defconfig | 1 + >>> configs/ls2080ardb_nand_defconfig | 2 ++ >>> 7 files changed, 8 insertions(+) >> >> Sriram, >> >> Please retest ls2080ardb_nand. It fails in my build. >> >> "undefined reference to `dm_scan_fdt_dev'" >> > > Hello York, > > As of now, nand boot is disfeatured and hence, the config is missing some features NAND boot may be defeatured for the SDK, but not for U-Boot. It is not big burden to maintain it. Let's keep it running, shall we? > for the nand boot. For this case, as the device tree is not enabled, the function isn’t > compiled. Setting CONFIG_OF_CONTROL and CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb" > will make it compile without errors. > > However, I will remove the the USB DM feature for nand in the next revision. Can you add the device tree support for NAND boot? York
>From: york sun >Sent: Thursday, October 06, 2016 9:33 PM >To: Sriram Dash <sriram.dash@nxp.com>; u-boot@lists.denx.de >Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; >albert.u.boot@aribaud.net; Suresh Gupta <suresh.gupta@nxp.com> >Subject: Re: [PATCH 1/2] armv8: ls2080: Enable CONFIG_DM_USB in defconfigs > >On 10/05/2016 11:03 PM, Sriram Dash wrote: >>> From: york sun >>> Sent: Thursday, October 06, 2016 12:37 AM >>> To: Sriram Dash <sriram.dash@nxp.com>; u-boot@lists.denx.de >>> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; >>> albert.u.boot@aribaud.net; Suresh Gupta <suresh.gupta@nxp.com> >>> Subject: Re: [PATCH 1/2] armv8: ls2080: Enable CONFIG_DM_USB in >>> defconfigs >>> >>> On 09/28/2016 11:18 PM, Sriram Dash wrote: >>>> Enables driver model flag CONFIG_DM_USB for LS2080A platform >>>> defconfigs. >>>> >>>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com> >>>> --- >>>> configs/ls2080aqds_SECURE_BOOT_defconfig | 1 + >>>> configs/ls2080aqds_defconfig | 1 + >>>> configs/ls2080aqds_nand_defconfig | 1 + >>>> configs/ls2080aqds_qspi_defconfig | 1 + >>>> configs/ls2080ardb_SECURE_BOOT_defconfig | 1 + >>>> configs/ls2080ardb_defconfig | 1 + >>>> configs/ls2080ardb_nand_defconfig | 2 ++ >>>> 7 files changed, 8 insertions(+) >>> >>> Sriram, >>> >>> Please retest ls2080ardb_nand. It fails in my build. >>> >>> "undefined reference to `dm_scan_fdt_dev'" >>> >> >> Hello York, >> >> As of now, nand boot is disfeatured and hence, the config is missing >> some features > >NAND boot may be defeatured for the SDK, but not for U-Boot. It is not big burden >to maintain it. Let's keep it running, shall we? > OK. >> for the nand boot. For this case, as the device tree is not enabled, >> the function isn't compiled. Setting CONFIG_OF_CONTROL and >CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb" >> will make it compile without errors. >> >> However, I will remove the the USB DM feature for nand in the next revision. > >Can you add the device tree support for NAND boot? > Sure. I will add the support for the device tree in next patch rev. >York
diff --git a/configs/ls2080aqds_SECURE_BOOT_defconfig b/configs/ls2080aqds_SECURE_BOOT_defconfig index 6a434c0..31e69b4 100644 --- a/configs/ls2080aqds_SECURE_BOOT_defconfig +++ b/configs/ls2080aqds_SECURE_BOOT_defconfig @@ -33,6 +33,7 @@ CONFIG_FSL_DSPI=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_RSA=y CONFIG_SPL_RSA=y diff --git a/configs/ls2080aqds_defconfig b/configs/ls2080aqds_defconfig index 53d5774..af52818 100644 --- a/configs/ls2080aqds_defconfig +++ b/configs/ls2080aqds_defconfig @@ -33,5 +33,6 @@ CONFIG_FSL_DSPI=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y diff --git a/configs/ls2080aqds_nand_defconfig b/configs/ls2080aqds_nand_defconfig index 8eb4121..f09809d 100644 --- a/configs/ls2080aqds_nand_defconfig +++ b/configs/ls2080aqds_nand_defconfig @@ -42,5 +42,6 @@ CONFIG_FSL_QSPI=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y diff --git a/configs/ls2080aqds_qspi_defconfig b/configs/ls2080aqds_qspi_defconfig index 5917f60..2b24a94 100644 --- a/configs/ls2080aqds_qspi_defconfig +++ b/configs/ls2080aqds_qspi_defconfig @@ -34,5 +34,6 @@ CONFIG_FSL_QSPI=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y diff --git a/configs/ls2080ardb_SECURE_BOOT_defconfig b/configs/ls2080ardb_SECURE_BOOT_defconfig index 932a4bd..a62d864 100644 --- a/configs/ls2080ardb_SECURE_BOOT_defconfig +++ b/configs/ls2080ardb_SECURE_BOOT_defconfig @@ -33,6 +33,7 @@ CONFIG_FSL_DSPI=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_RSA=y CONFIG_SPL_RSA=y diff --git a/configs/ls2080ardb_defconfig b/configs/ls2080ardb_defconfig index c477961..bbf2a74 100644 --- a/configs/ls2080ardb_defconfig +++ b/configs/ls2080ardb_defconfig @@ -33,5 +33,6 @@ CONFIG_FSL_DSPI=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y diff --git a/configs/ls2080ardb_nand_defconfig b/configs/ls2080ardb_nand_defconfig index 551f158..cdeb1dd 100644 --- a/configs/ls2080ardb_nand_defconfig +++ b/configs/ls2080ardb_nand_defconfig @@ -31,9 +31,11 @@ CONFIG_NET_RANDOM_ETHADDR=y CONFIG_NETDEVICES=y CONFIG_E1000=y CONFIG_SYS_NS16550=y +CONFIG_DM=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y +CONFIG_DM_USB=y CONFIG_USB_STORAGE=y CONFIG_OF_LIBFDT=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
Enables driver model flag CONFIG_DM_USB for LS2080A platform defconfigs. Signed-off-by: Sriram Dash <sriram.dash@nxp.com> --- configs/ls2080aqds_SECURE_BOOT_defconfig | 1 + configs/ls2080aqds_defconfig | 1 + configs/ls2080aqds_nand_defconfig | 1 + configs/ls2080aqds_qspi_defconfig | 1 + configs/ls2080ardb_SECURE_BOOT_defconfig | 1 + configs/ls2080ardb_defconfig | 1 + configs/ls2080ardb_nand_defconfig | 2 ++ 7 files changed, 8 insertions(+)